From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 06/15] env: fat: Make the debug messages play a little nicer
Date: Thu, 18 Jan 2018 16:12:50 +0100 [thread overview]
Message-ID: <20180118151250.h3whxfhce3pfrgyf@flea.lan> (raw)
In-Reply-To: <CAPnjgZ218SsJvBfKJwWLq_wq=+vtE7kT0pxmVnyApfaBjLn9Uw@mail.gmail.com>
On Wed, Jan 17, 2018 at 03:03:47PM -0700, Simon Glass wrote:
> Hi Maxime,
>
> On 16 January 2018 at 01:16, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > Since we have global messages to indicate what's going on, the custom
> > messages in the environment drivers only make the output less readable.
> >
> > Make FAT play a little nicer by removing all the extra \n and formatting
> > that is redundant with the global output.
> >
> > Reviewed-by: Andre Przywara <andre.przywara@arm.com>
> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > ---
> > env/fat.c | 25 ++++++++++++++++++++-----
> > 1 file changed, 20 insertions(+), 5 deletions(-)
>
> Do you have a change log for this patch?
Sorry, it was buried in my cover letter.
You have the diff here:
http://code.bulix.org/g3emu3-259575
tl; dr: I added some comments around the printf's to make it obvious
that the missing \n were intentional.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180118/8f29238e/attachment.sig>
next prev parent reply other threads:[~2018-01-18 15:12 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 9:16 [U-Boot] [PATCH v2 00/15] env: Multiple env support and env transition for sunxi Maxime Ripard
2018-01-16 9:16 ` [U-Boot] [PATCH v2 01/15] cmd: nvedit: Get rid of the env lookup Maxime Ripard
2018-01-16 9:16 ` [U-Boot] [PATCH v2 02/15] env: Rename env_driver_lookup_default and env_get_default_location Maxime Ripard
2018-01-16 9:16 ` [U-Boot] [PATCH v2 03/15] env: Pass additional parameters to the env lookup function Maxime Ripard
2018-01-17 22:03 ` Simon Glass
2018-01-18 14:54 ` Maxime Ripard
2018-01-16 9:16 ` [U-Boot] [PATCH v2 04/15] env: Make the env save message a bit more explicit Maxime Ripard
2018-01-16 9:16 ` [U-Boot] [PATCH v2 05/15] env: Make it explicit where we're loading our environment from Maxime Ripard
2018-01-16 9:16 ` [U-Boot] [PATCH v2 06/15] env: fat: Make the debug messages play a little nicer Maxime Ripard
2018-01-17 22:03 ` Simon Glass
2018-01-18 15:12 ` Maxime Ripard [this message]
2018-01-16 9:16 ` [U-Boot] [PATCH v2 07/15] env: mmc: " Maxime Ripard
2018-01-17 22:07 ` Simon Glass
2018-01-16 9:16 ` [U-Boot] [PATCH v2 08/15] env: common: " Maxime Ripard
2018-01-17 22:07 ` Simon Glass
2018-01-16 9:16 ` [U-Boot] [PATCH v2 09/15] env: Support multiple environments Maxime Ripard
2018-01-16 9:16 ` [U-Boot] [PATCH v2 10/15] env: Initialise all the environments Maxime Ripard
2018-01-17 22:07 ` Simon Glass
2018-01-16 9:16 ` [U-Boot] [PATCH v2 11/15] env: mmc: depends on the MMC framework Maxime Ripard
2018-01-17 22:07 ` Simon Glass
2018-01-16 9:16 ` [U-Boot] [PATCH v2 12/15] env: Allow to build multiple environments in Kconfig Maxime Ripard
2018-01-16 9:16 ` [U-Boot] [PATCH v2 13/15] env: Mark env_get_location as weak Maxime Ripard
2018-01-17 22:07 ` Simon Glass
2018-01-18 17:21 ` Maxime Ripard
2018-01-22 0:29 ` Simon Glass
2018-01-22 12:46 ` Maxime Ripard
2018-01-22 12:49 ` Tom Rini
2018-01-22 15:57 ` Maxime Ripard
2018-01-22 16:36 ` Tom Rini
2018-01-22 16:48 ` Simon Glass
2018-01-22 17:08 ` Tom Rini
2018-01-16 9:16 ` [U-Boot] [PATCH v2 14/15] sunxi: Transition from the MMC to a FAT-based environment Maxime Ripard
2018-01-16 9:16 ` [U-Boot] [PATCH v2 15/15] env: sunxi: Enable FAT-based environment support by default Maxime Ripard
2018-01-16 21:56 ` [U-Boot] [PATCH v2 00/15] env: Multiple env support and env transition for sunxi Tom Rini
2018-01-17 8:58 ` Maxime Ripard
2018-01-17 13:01 ` Tom Rini
2018-01-17 13:27 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180118151250.h3whxfhce3pfrgyf@flea.lan \
--to=maxime.ripard@free-electrons.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).