From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, 1/4] serial: ns16550: da8xx (freon/primus) is not omap-like
Date: Fri, 19 Jan 2018 10:41:15 -0500 [thread overview]
Message-ID: <20180119154115.GV4660@bill-the-cat> (raw)
In-Reply-To: <CAALWOA-R=EAnOQY5JA+=PgXYOwuSgbVzDyXCkxbgdV7MwAh_tQ@mail.gmail.com>
On Fri, Jan 19, 2018 at 04:39:15PM +0100, Matthijs van Duin wrote:
> On 19 January 2018 at 16:26, Tom Rini <trini@konsulko.com> wrote:
> > This introduces a warning on all SOC_DA8XX systems because they do not
> > set CONFIG_SYS_NS16550_MEM32 so serial_out is writeb
>
> Well that's a mistake. Its uart uses 32-bit registers, and 8-bit
> access is not documented to be acceptable.
>
> Apologies for forgetting to at least compile-test this for all
> affected targets, I really should have done that.
>
> > Are you able to test SOC_DA8XX platforms?
>
> No, this was based on my knowledge that freon/primus SoCs
> (OMAP-L1xx/AM1xxx/TMS320C674x/DA8xx) are architecturally members of
> the TI C6x family and not remotely related to the OMAP (despite the
> part code "OMAP-L1xx"), and I double-checked the technical reference
> manual: their UART is identical to that on Keystone.
OK. For v2, if you can convert CONFIG_SYS_NS16550_MEM32 to Kconfig as
well I'd appreciate it. I'll see about digging out and setting up one
of my da8xx platforms for a quick runtime test too. Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180119/0071f9a5/attachment.sig>
next prev parent reply other threads:[~2018-01-19 15:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 12:50 [U-Boot] [PATCH 1/4] serial: ns16550: da8xx (freon/primus) is not omap-like Matthijs van Duin
2018-01-19 15:26 ` [U-Boot] [U-Boot, " Tom Rini
2018-01-19 15:39 ` Matthijs van Duin
2018-01-19 15:41 ` Tom Rini [this message]
2018-01-19 16:39 ` Matthijs van Duin
2018-01-19 20:22 ` Tom Rini
2018-01-19 20:34 ` Adam Ford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180119154115.GV4660@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox