From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v2, 5/5] mmc: omap_hsmmc: Fix incorrect bit operations for disabling a bit
Date: Fri, 19 Jan 2018 16:11:33 -0500 [thread overview]
Message-ID: <20180119211133.GE4660@bill-the-cat> (raw)
In-Reply-To: <1506005496-8635-6-git-send-email-jjhiblot@ti.com>
On Thu, Sep 21, 2017 at 04:51:36PM +0200, Jean-Jacques Hiblot wrote:
> From: Kishon Vijay Abraham I <kishon@ti.com>
>
> omap_hsmmc driver uses "|" in a couple of places for disabling a bit.
> While it's okay to use it in "mmc_reg_out" (since mmc_reg_out has a
> _mask_ argument to take care of resetting a bit), it's incorrectly used
> for resetting flags in "omap_hsmmc_send_cmd".
>
> Fix it here by using "&= ~()" to reset a bit.
>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180119/276daad5/attachment.sig>
next prev parent reply other threads:[~2018-01-19 21:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170921145151epcas2p3484ad63ce7e0b518a64fc505e5d12ef0@epcas2p3.samsung.com>
2017-09-21 14:51 ` [U-Boot] [PATCH v2 0/5] mmc: omap_hsmmc: Add support for ADMA Jean-Jacques Hiblot
2017-09-21 14:51 ` [U-Boot] [PATCH v2 1/5] Revert "omap_hsmmc: update struct hsmmc to accommodate omap3 from DT" Jean-Jacques Hiblot
2017-09-24 14:39 ` Tom Rini
2017-09-25 2:03 ` Jaehoon Chung
2018-01-19 21:11 ` [U-Boot] [U-Boot, v2, " Tom Rini
2017-09-21 14:51 ` [U-Boot] [PATCH v2 2/5] omap: Update the base address of the MMC controllers Jean-Jacques Hiblot
2017-09-24 14:40 ` Tom Rini
2018-01-19 21:11 ` [U-Boot] [U-Boot, v2, " Tom Rini
2017-09-21 14:51 ` [U-Boot] [PATCH v2 3/5] mmc: omap_hsmmc: Add support for DMA (ADMA2) Jean-Jacques Hiblot
2017-09-24 14:40 ` Tom Rini
2018-01-19 21:11 ` [U-Boot] [U-Boot, v2, " Tom Rini
2017-09-21 14:51 ` [U-Boot] [PATCH v2 4/5] mmc: omap_hsmmc: Enable Auto command (CMD12) enable Jean-Jacques Hiblot
2017-09-24 14:40 ` Tom Rini
2018-01-19 21:11 ` [U-Boot] [U-Boot, v2, " Tom Rini
2017-09-21 14:51 ` [U-Boot] [PATCH v2 5/5] mmc: omap_hsmmc: Fix incorrect bit operations for disabling a bit Jean-Jacques Hiblot
2017-09-24 14:40 ` Tom Rini
2018-01-19 21:11 ` Tom Rini [this message]
2017-09-22 14:20 ` [U-Boot] [PATCH v2 0/5] mmc: omap_hsmmc: Add support for ADMA Jaehoon Chung
2017-09-25 2:15 ` Simon Glass
2017-09-25 5:26 ` Jaehoon Chung
2017-11-07 16:01 ` Jean-Jacques Hiblot
2017-09-25 6:05 ` Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180119211133.GE4660@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox