[U-Boot] [PATCH v3 04/10] mips: bmips: add bcm63xx-spi driver support for BCM6338

Álvaro Fernández Rojas
2017-06-07T18:29:46Z

Hi Jagan,

El 07/06/2017 a las 19:30, Jagan Teki escribió:
> On Wed, Jun 7, 2017 at 9:08 PM, Álvaro Fernández Rojas
> <noltari@gmail.com> wrote:
>>
>>
>> El 7/6/17 a las 10:00, Jagan Teki escribió:
>>> On Sat, Jun 3, 2017 at 3:27 PM, Álvaro Fernández Rojas
>>> <noltari@gmail.com> wrote:
>>>> This driver manages the SPI controller present on this SoC.
>>>>
>>>> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
>>>> ---
>>>> v3: rename BCM6338 SPI driver to BCM6348
>>>> v2: add spi alias
>>>>
>>>> arch/mips/dts/brcm,bcm6338.dtsi | 17 +++++++++++++++++
>>>> 1 file changed, 17 insertions(+)
>>>>
>>>> diff --git a/arch/mips/dts/brcm,bcm6338.dtsi b/arch/mips/dts/brcm,bcm6338.dtsi
>>>> index eb51a43..0cab44c 100644
>>>> --- a/arch/mips/dts/brcm,bcm6338.dtsi
>>>> +++ b/arch/mips/dts/brcm,bcm6338.dtsi
>>>> @@ -12,6 +12,10 @@
>>>> / {
>>>> compatible = "brcm,bcm6338";
>>>>
>>>> + aliases {
>>>> + spi0 = &spi;
>>>> + };
>>>> +
>>>> cpus {
>>>> reg = <0xfffe0000 0x4>;
>>>> #address-cells = <1>;
>>>> @@ -109,6 +113,19 @@
>>>> status = "disabled";
>>>> };
>>>>
>>>> + spi: spi at fffe0c00 {
>>>> + compatible = "brcm,bcm6348-spi";
>>>> + reg = <0xfffe0c00 0xc0>;
>>>> + #address-cells = <1>;
>>>> + #size-cells = <0>;
>>>> + clocks = <&periph_clk BCM6338_CLK_SPI>;
>>>> + resets = <&periph_rst BCM6338_RST_SPI>;
>>>> + spi-max-frequency = <20000000>;
>>>> + num-cs = <4>;
>>>> +
>>>
>>> space?
>> I added that space on every disabled node for all the bmips .dtsi files...
>> If you really want it removed I can do that, but it won't be in line with other nodes.
>>
>>>
>>>> + status = "disabled";
>>>> + };
>>>
>>> As per dts(or with new node) additions/update we generally rely with
>>> Linux for maximum possible extent So can you try to add this in Linux
>>> first so-that we can have proper sync.
>> Actually it's already upstream (even though there aren't any users yet):
>> https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/spi/spi-bcm63xx.txt
>
> But what about dts file, already in upstream?
Nope, these boards aren't in upstream since we use them for LEDE/OpenWrt and support has never been upstreamed.
Appart from that, there are currently two targets for bcm63xx -> brcm63xx and bmips, and every driver is being adapted to device tree slowly (adding support for bmips too).

>
> thanks!
>
Thanks.