* [U-Boot] [PATCH] usb: xhci: Fix bool initialization in xhci_bulk_tx
@ 2018-01-20 8:37 Gustavo A. R. Silva
2018-01-21 16:49 ` Marek Vasut
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2018-01-20 8:37 UTC (permalink / raw)
To: u-boot
Bool initializations should use true and false.
This issue was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Cc: Bin Meng <bmeng.cn@gmail.com>
Cc: Marek Vasut <marex@denx.de>
---
drivers/usb/host/xhci-ring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index 579e670..7599c91 100644
--- a/drivers/usb/host/xhci-ring.c
+++ b/drivers/usb/host/xhci-ring.c
@@ -557,7 +557,7 @@ int xhci_bulk_tx(struct usb_device *udev, unsigned long pipe,
{
int num_trbs = 0;
struct xhci_generic_trb *start_trb;
- bool first_trb = 0;
+ bool first_trb = false;
int start_cycle;
u32 field = 0;
u32 length_field = 0;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* [U-Boot] [PATCH] usb: xhci: Fix bool initialization in xhci_bulk_tx
2018-01-20 8:37 [U-Boot] [PATCH] usb: xhci: Fix bool initialization in xhci_bulk_tx Gustavo A. R. Silva
@ 2018-01-21 16:49 ` Marek Vasut
2018-01-22 1:58 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2018-01-21 16:49 UTC (permalink / raw)
To: u-boot
On 01/20/2018 09:37 AM, Gustavo A. R. Silva wrote:
> Bool initializations should use true and false.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> Cc: Bin Meng <bmeng.cn@gmail.com>
> Cc: Marek Vasut <marex@denx.de>
Applied, thanks
> ---
> drivers/usb/host/xhci-ring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
> index 579e670..7599c91 100644
> --- a/drivers/usb/host/xhci-ring.c
> +++ b/drivers/usb/host/xhci-ring.c
> @@ -557,7 +557,7 @@ int xhci_bulk_tx(struct usb_device *udev, unsigned long pipe,
> {
> int num_trbs = 0;
> struct xhci_generic_trb *start_trb;
> - bool first_trb = 0;
> + bool first_trb = false;
> int start_cycle;
> u32 field = 0;
> u32 length_field = 0;
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 3+ messages in thread* [U-Boot] [PATCH] usb: xhci: Fix bool initialization in xhci_bulk_tx
2018-01-21 16:49 ` Marek Vasut
@ 2018-01-22 1:58 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2018-01-22 1:58 UTC (permalink / raw)
To: u-boot
Quoting Marek Vasut <marek.vasut@gmail.com>:
> On 01/20/2018 09:37 AM, Gustavo A. R. Silva wrote:
>> Bool initializations should use true and false.
>>
>> This issue was detected with the help of Coccinelle.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> Cc: Bin Meng <bmeng.cn@gmail.com>
>> Cc: Marek Vasut <marex@denx.de>
>
> Applied, thanks
>
Thank you, Marek. This is my very first contribution to the Das U-Boot
project. :)
--
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-22 1:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-20 8:37 [U-Boot] [PATCH] usb: xhci: Fix bool initialization in xhci_bulk_tx Gustavo A. R. Silva
2018-01-21 16:49 ` Marek Vasut
2018-01-22 1:58 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox