From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Convert CONFIG_SYS_BOOT_GET_{CMDLINE, KBD} to Kconfig
Date: Mon, 22 Jan 2018 16:42:53 -0500 [thread overview]
Message-ID: <20180122214253.GA19414@bill-the-cat> (raw)
In-Reply-To: <20171228072513.1068-1-woods.technical@gmail.com>
On Thu, Dec 28, 2017 at 01:25:13AM -0600, Derald D. Woods wrote:
> This converts the following to Kconfig:
> CONFIG_SYS_BOOT_GET_CMDLINE
> CONFIG_SYS_BOOT_GET_KBD
>
> Additionally, ARM now selects CONFIG_SYS_BOOT_GET_CMDLINE. This enables
> the 'boot_get_cmdline' call to be reached from 'image_setup_linux' in
> "common/image.c".
>
> Signed-off-by: Derald D. Woods <woods.technical@gmail.com>
> ---
> Kconfig | 12 ++++++++++++
> arch/Kconfig | 5 +++++
> arch/m68k/include/asm/config.h | 2 --
> arch/powerpc/include/asm/config.h | 2 --
> scripts/config_whitelist.txt | 2 --
> 5 files changed, 17 insertions(+), 6 deletions(-)
Why are you enabling this on ARM as well here? It causes a size grow
(of course, we're adding in a function) on all ARM boards and I don't
quite see why we need to put a copy of the bootargs in that location.
Off the top of my head it seems like it only makes sense on pre-DTB
PowerPC where the cmdline needed to be in a good location. On pre-DTB
ARM that's done via ATAGS instead, so already covered. Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180122/3bc753b5/attachment.sig>
next prev parent reply other threads:[~2018-01-22 21:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-28 7:25 [U-Boot] [PATCH] Convert CONFIG_SYS_BOOT_GET_{CMDLINE, KBD} to Kconfig Derald D. Woods
2018-01-22 21:42 ` Tom Rini [this message]
2018-01-22 23:17 ` [U-Boot] [PATCH v2] " Derald D. Woods
2018-01-31 0:48 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180122214253.GA19414@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox