From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Date: Wed, 24 Jan 2018 23:32:34 +0100 Subject: [U-Boot] [PATCH 2/8] spl: nand: sunxi: Fix second case of modulo by zero error In-Reply-To: <20180124074731.7olf475c2d7ne7co@flea.lan> References: <20180124004454.5759-1-miquel.raynal@free-electrons.com> <20180124004454.5759-3-miquel.raynal@free-electrons.com> <20180124074731.7olf475c2d7ne7co@flea.lan> Message-ID: <20180124233234.3a7650ba@xps13> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: u-boot@lists.denx.de Hi Maxime, On Wed, 24 Jan 2018 08:47:31 +0100 Maxime Ripard wrote: > On Wed, Jan 24, 2018 at 01:44:48AM +0100, Miquel Raynal wrote: > > In the nand_read_buffer() step, the seed is calculated by doing a modulo > > by conf->nseeds which is always zero when not using the randomizer (most > > of SLC NANDs). > >=20 > > This situation turns out to lead to a run time freeze. > >=20 > > Derive this seed only when the randomizer is enabled (and conf->nseeds > > logically not zero). =20 >=20 > Mentionning the first occurence of that issue in your commit log would > be great, especially since the situation depends on configuration > options. Absolutely, I added a reference in the commit message to: ea3f750c73e3 ("nand: sunxi: Fix modulo by zero error") Thanks, Miqu=C3=A8l