From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Thu, 25 Jan 2018 11:26:19 +0100 Subject: [U-Boot] [RFC PATCH] Allow providing default environment from file In-Reply-To: <02e89a9e-bcd1-480c-ac9e-4c383789cf60@prevas.dk> References: <20180124095559.28317-1-rasmus.villemoes@prevas.dk> <20180125103037.1ca9fa1e@jawa> <02e89a9e-bcd1-480c-ac9e-4c383789cf60@prevas.dk> Message-ID: <20180125112619.020e93cb@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Rasmus, > On 2018-01-25 10:30, Lukasz Majewski wrote: > > Hi Rasmus, > > > >> It is sometimes useful to be able to define the entire default > >> environment in an external file. > > > > There is already available script for extracting the environment. > > > > Please look into: > > ./scripts/get_default_envs.sh > > > > Maybe you can reuse it in this patch? > > I'm sorry, but I don't see what I could use that for. It seems to do > the opposite of what I want, Sorry. I have had misunderstood the patch description. > namely extract the default environment > and store it in a plain-text file. I want to provide a plain-text > file to define the default environment. Ok. Then your patch seems perfectly valid. > > It's quite likely that that script can be useful for generating a > sketch for the external file (i.e., build a U-boot as "usual" with > default environment built from various config options etc. etc., then > hand-edit that file to remove redundant stuff and add the things one > needs). The thing is, having the default environment in an external > file makes it much easier to put it under version control than having > to maintain a branch inside the U-boot repo just to tweak > CONFIG_EXTRA_ENV_SETTINGS. > > Rasmus Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: