From: Miquel Raynal <miquel.raynal@free-electrons.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/8] spl: nand: sunxi: Enhancements and cleaning
Date: Fri, 26 Jan 2018 00:34:47 +0100 [thread overview]
Message-ID: <20180126003447.7eb8de48@xps13> (raw)
In-Reply-To: <20180124075638.s4bhtrwrpowzkwgj@flea.lan>
Hi Maxime,
On Wed, 24 Jan 2018 08:56:38 +0100
Maxime Ripard <maxime.ripard@free-electrons.com> wrote:
> Hi,
>
> On Wed, Jan 24, 2018 at 01:44:50AM +0100, Miquel Raynal wrote:
> > Do some cleaning in sunxi NAND SPL driver like adding helpers and
> > clearing flags at the right spot
> >
> > Signed-off-by: Miquel Raynal <miquel.raynal@free-electrons.com>
>
> I'm not really fond of these kind of wildcard patches, especially
> since..
>
[...]
>
> Overall, I think it would be great to split that patch into 4:
> - the first one to fix the ADR vs ADDR typo (without changing the order)
> - the second one to introduce the nand_wait_int helper
> - the third one to introduce the nand_wait_cmd_fifo_empty, with a
> proper commit log explaining why this needs to be done and which
> issues is it fixing
> - And maybe if justified moving the ecc_bytes array to global scope
I split this patch into 4 logical peaces, as requested.
Thanks,
Miquèl
next prev parent reply other threads:[~2018-01-25 23:34 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 0:44 [U-Boot] [PATCH 0/8] Bring NAND support to Nintendo NES Classic Miquel Raynal
2018-01-24 0:44 ` [U-Boot] [PATCH 1/8] mtd: nand: sunxi: Fix strength minimum value Miquel Raynal
2018-01-24 7:46 ` Maxime Ripard
2018-01-24 22:21 ` Miquel Raynal
2018-01-24 7:57 ` Boris Brezillon
2018-01-24 22:19 ` Miquel Raynal
2018-01-24 0:44 ` [U-Boot] [PATCH 2/8] spl: nand: sunxi: Fix second case of modulo by zero error Miquel Raynal
2018-01-24 7:47 ` Maxime Ripard
2018-01-24 22:32 ` Miquel Raynal
2018-01-24 0:44 ` [U-Boot] [PATCH 3/8] sunxi: Allow SPL to be compiled for sun8i platforms Miquel Raynal
2018-01-24 7:49 ` Maxime Ripard
2018-01-24 22:37 ` Miquel Raynal
2018-01-24 0:44 ` [U-Boot] [PATCH 4/8] spl: nand: sunxi: Enhancements and cleaning Miquel Raynal
2018-01-24 7:56 ` Maxime Ripard
2018-01-25 23:34 ` Miquel Raynal [this message]
2018-01-24 8:06 ` Boris Brezillon
2018-01-25 23:37 ` Miquel Raynal
2018-01-24 0:44 ` [U-Boot] [PATCH 5/8] spl: nand: sunxi: use PIO instead of DMA Miquel Raynal
2018-01-24 8:06 ` Maxime Ripard
2018-01-24 8:26 ` Boris Brezillon
2018-01-24 8:39 ` Maxime Ripard
2018-01-25 23:58 ` Miquel Raynal
2018-01-24 8:16 ` Boris Brezillon
2018-01-26 0:09 ` Miquel Raynal
2018-01-24 0:44 ` [U-Boot] [PATCH 6/8] configs: Add NAND support for NES Classic Miquel Raynal
2018-01-24 8:10 ` Maxime Ripard
2018-01-24 0:44 ` [U-Boot] [PATCH 7/8] sunxi: dts: Add NAND node to sun8i DTSI Miquel Raynal
2018-01-24 8:16 ` Maxime Ripard
2018-01-24 0:44 ` [U-Boot] [PATCH 8/8] sunxi: dts: Enable NAND on NES classic Miquel Raynal
2018-01-24 8:18 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180126003447.7eb8de48@xps13 \
--to=miquel.raynal@free-electrons.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox