From mboxrd@z Thu Jan  1 00:00:00 1970
From: Miquel Raynal <miquel.raynal@free-electrons.com>
Date: Fri, 26 Jan 2018 00:34:47 +0100
Subject: [U-Boot] [PATCH 4/8] spl: nand: sunxi: Enhancements and cleaning
In-Reply-To: <20180124075638.s4bhtrwrpowzkwgj@flea.lan>
References: <20180124004454.5759-1-miquel.raynal@free-electrons.com>
 <20180124004454.5759-5-miquel.raynal@free-electrons.com>
 <20180124075638.s4bhtrwrpowzkwgj@flea.lan>
Message-ID: <20180126003447.7eb8de48@xps13>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
To: u-boot@lists.denx.de

Hi Maxime,

On Wed, 24 Jan 2018 08:56:38 +0100
Maxime Ripard <maxime.ripard@free-electrons.com> wrote:

> Hi,
>=20
> On Wed, Jan 24, 2018 at 01:44:50AM +0100, Miquel Raynal wrote:
> > Do some cleaning in sunxi NAND SPL driver like adding helpers and
> > clearing flags at the right spot
> >=20
> > Signed-off-by: Miquel Raynal <miquel.raynal@free-electrons.com> =20
>=20
> I'm not really fond of these kind of wildcard patches, especially
> since..
>=20

[...]

>=20
> Overall, I think it would be great to split that patch into 4:
>   - the first one to fix the ADR vs ADDR typo (without changing the order)
>   - the second one to introduce the nand_wait_int helper
>   - the third one to introduce the nand_wait_cmd_fifo_empty, with a
>     proper commit log explaining why this needs to be done and which
>     issues is it fixing
>   - And maybe if justified moving the ecc_bytes array to global scope

I split this patch into 4 logical peaces, as requested.

Thanks,
Miqu=C3=A8l