From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] atomic-long: Fix warnings on arm64
Date: Sun, 28 Jan 2018 13:53:02 -0500 [thread overview]
Message-ID: <20180128185302.GF20149@bill-the-cat> (raw)
In-Reply-To: <20180127031104.2353-1-bradleybolen@gmail.com>
On Fri, Jan 26, 2018 at 10:11:04PM -0500, Bradley Bolen wrote:
> Several inline functions in this file reference undefined functions in
> U-Boot. For example:
>
> atomic-long.h:73:9: warning: implicit declaration of function
> 'atomic64_sub_and_test'
> atomic-long.h:80:9: warning: implicit declaration of function
> 'atomic64_dec_and_test'
> atomic-long.h:87:9: warning: implicit declaration of function
> 'atomic64_inc_and_test'
>
> Handle this the same as the 32 bit build by wrapping these functions in
> a __UBOOT__ check.
>
> Signed-off-by: Bradley Bolen <bradleybolen@gmail.com>
Applied to u-boot/master, thanks!
[Michal, I think this ends up being easier to maintain long-term than
your RFC patch that removed all of these functions]
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180128/981e38fa/attachment.sig>
prev parent reply other threads:[~2018-01-28 18:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-27 3:11 [U-Boot] [PATCH] atomic-long: Fix warnings on arm64 Bradley Bolen
2018-01-28 18:53 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180128185302.GF20149@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox