From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v3, 3/6] tools: include necessary headers explicitly
Date: Sun, 28 Jan 2018 13:54:00 -0500 [thread overview]
Message-ID: <20180128185400.GU20149@bill-the-cat> (raw)
In-Reply-To: <1516529958-16441-3-git-send-email-yamada.masahiro@socionext.com>
On Sun, Jan 21, 2018 at 07:19:15PM +0900, Masahiro Yamada wrote:
> Several host-tools use "bool" type without including <stdbool.h>.
> This relies on the crappy header inclusion chain.
>
> tools/Makefile has the following line:
>
> HOST_EXTRACFLAGS += -include $(srctree)/include/libfdt_env.h \
>
> All host-tools are forced to include libfdt_env.h even if they are
> totally unrelated to FDT. Then, <stdbool.h> is indirectly included
> as follows:
>
> include/libfdt_env.h
> -> include/linux/types.h
> -> <stdbool.h>
>
> I am fixing this horrible crap. In advance, I need to add necessary
> include directives explicitly. tools/fdtgrep.c needs more; <fctl.h>
> for open() and <errno.h> for errno.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Reviewed-by: Joe Hershberger <joe.hershberger@ni.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180128/8cd549dc/attachment.sig>
next prev parent reply other threads:[~2018-01-28 18:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-21 10:19 [U-Boot] [PATCH v3 1/6] libfdt: migrate fdt_rw.c to a wrapper of scripts/dtc/libfdt/fdt_rw.c Masahiro Yamada
2018-01-21 10:19 ` [U-Boot] [PATCH v3 2/6] libfdt: fix <linux/libfdt.h> Masahiro Yamada
2018-01-28 18:53 ` [U-Boot] [U-Boot,v3,2/6] " Tom Rini
2018-01-21 10:19 ` [U-Boot] [PATCH v3 3/6] tools: include necessary headers explicitly Masahiro Yamada
2018-01-28 18:54 ` Tom Rini [this message]
2018-01-21 10:19 ` [U-Boot] [PATCH v3 4/6] libfdt: move working_fdt and FDT_RAMDISK_OVERHEAD to include/libfdt.h Masahiro Yamada
2018-01-28 18:54 ` [U-Boot] [U-Boot, v3, " Tom Rini
2018-01-21 10:19 ` [U-Boot] [PATCH v3 5/6] libfdt: migrate libfdt.h to a wrapper + U-Boot own code Masahiro Yamada
2018-01-28 18:54 ` [U-Boot] [U-Boot, v3, " Tom Rini
2018-01-21 10:19 ` [U-Boot] [PATCH v3 6/6] libfdt: migrate include/libfdt_env.h to a wrapper Masahiro Yamada
2018-01-28 18:54 ` [U-Boot] [U-Boot, v3, " Tom Rini
2018-01-28 18:53 ` [U-Boot] [U-Boot, v3, 1/6] libfdt: migrate fdt_rw.c to a wrapper of scripts/dtc/libfdt/fdt_rw.c Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180128185400.GU20149@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox