[U-Boot] [U-Boot, v3, 01/15] serial: Use next serial device if probing fails

Alexander Graf
2018-01-29T10:17:45Z

On 29.01.18 04:27, Derald D. Woods wrote:
> On Sun, Jan 28, 2018 at 01:54:50PM -0500, Tom Rini wrote:
>> On Thu, Jan 25, 2018 at 12:05:42PM +0100, Alexander Graf wrote:
>>
>>> Currently our serial device search chokes on the fact that the serial
>>> probe function could fail. If it does, instead of searching for the next
>>> usable serial device, it just quits.
>>>
>>> This patch changes the fallback logic so that even when a serial device
>>> was not probed correctly, we just try the next ones until we find one that
>>> works.
>>>
>>> Signed-off-by: Alexander Graf <agraf@suse.de>
>>> Reviewed-by: Simon Glass <sjg@chromium.org>
>>
>> Applied to u-boot/master, thanks!
>>
>> --
>> Tom
>
> Is there something, at the board level, that needs to be coded to
> support this patch? The omap3_evm fails to boot with this patch applied.
> Reverting it allows omap3_evm to boot again. I am testing with the base
> default config for omap3_evm.

No, this should really be a nop for everyone who does not fail probe()
in serial devices. I'll see if I can figure out what's causing the issue
in the next hours.

If I don't get down to the root cause by tonight, I'll send a small
patch that simply conditionalizes the new/old code based on a config
variable and turn it on only for the Rpis, so we have a working -rc1.

Alex