public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Shawn Guo <shawn.guo@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] mx6sabre_common: Allow building CONFIG_USB_FUNCTION_MASS_STORAGE
Date: Mon, 29 Jan 2018 09:56:08 +0800	[thread overview]
Message-ID: <20180129015606.GC12957@dragon> (raw)
In-Reply-To: <1517150943-21157-1-git-send-email-festevam@gmail.com>

On Sun, Jan 28, 2018 at 12:49:02PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> Selecting CONFIG_USB_FUNCTION_MASS_STORAGE=y in the defconfig leads to
> the following error:
> 
> cmd/built-in.o: In function `do_usb_mass_storage':
> cmd/usb_mass_storage.c:217: undefined reference to `fsg_main_thread'
> cmd/usb_mass_storage.c:170: undefined reference to `fsg_init'
> 
> CONFIG_USB_FUNCTION_MASS_STORAGE option is built only for
> the non-SPL case as per the logic in drivers/usb/gadget/Makefile,
> so remove the incorrect CONFIG_SPL ifdefery to fix the build
> failure.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

For both patches on imx6q-sabresd board,

Tested-by: Shawn Guo <shawn.guo@linaro.org>

  parent reply	other threads:[~2018-01-29  1:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-28 14:49 [U-Boot] [PATCH 1/2] mx6sabre_common: Allow building CONFIG_USB_FUNCTION_MASS_STORAGE Fabio Estevam
2018-01-28 14:49 ` [U-Boot] [PATCH 2/2] mx6sabresd: Select CONFIG_CMD_USB_MASS_STORAGE Fabio Estevam
2018-02-04 10:15   ` Stefano Babic
2018-01-29  1:56 ` Shawn Guo [this message]
2018-02-04 10:15 ` [U-Boot] [PATCH 1/2] mx6sabre_common: Allow building CONFIG_USB_FUNCTION_MASS_STORAGE Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180129015606.GC12957@dragon \
    --to=shawn.guo@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox