* [U-Boot] [PATCH v2] samsung: board: init the s2mps11 pmic during booting time [not found] <CGME20180129045322epcas1p46ad80065361454354b7c5488d67a83d8@epcas1p4.samsung.com> @ 2018-01-29 4:53 ` Jaehoon Chung 2018-01-29 9:12 ` Lukasz Majewski 0 siblings, 1 reply; 3+ messages in thread From: Jaehoon Chung @ 2018-01-29 4:53 UTC (permalink / raw) To: u-boot Exynos5422 board has s2mps11 pmic. If CONFIG_PMIC_S2MPS11 is enabled, it can initialize PMIC and Regulators during booting time. Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> Tested-by: Anand Moon <linux.amoon@gmail.com> --- Changelog on V2: - Fix the #endif location board/samsung/common/exynos5-dt.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/board/samsung/common/exynos5-dt.c b/board/samsung/common/exynos5-dt.c index a4eb351405..862644b00e 100644 --- a/board/samsung/common/exynos5-dt.c +++ b/board/samsung/common/exynos5-dt.c @@ -93,6 +93,9 @@ int exynos_power_init(void) struct udevice *dev; int ret; +#ifdef CONFIG_PMIC_S2MPS11 + ret = pmic_get("s2mps11_pmic", &dev); +#else ret = pmic_get("max77686", &dev); if (!ret) { /* TODO(sjg at chromium.org): Move into the clock/pmic API */ @@ -112,6 +115,7 @@ int exynos_power_init(void) s5m8767_enable_32khz_cp(dev); #endif } +#endif /* CONFIG_PMIC_S2MPS11 */ if (ret == -ENODEV) return 0; -- 2.15.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH v2] samsung: board: init the s2mps11 pmic during booting time 2018-01-29 4:53 ` [U-Boot] [PATCH v2] samsung: board: init the s2mps11 pmic during booting time Jaehoon Chung @ 2018-01-29 9:12 ` Lukasz Majewski 2018-01-30 5:18 ` Jaehoon Chung 0 siblings, 1 reply; 3+ messages in thread From: Lukasz Majewski @ 2018-01-29 9:12 UTC (permalink / raw) To: u-boot Hi Jaehoon, > Exynos5422 board has s2mps11 pmic. > If CONFIG_PMIC_S2MPS11 is enabled, it can initialize PMIC and > Regulators during booting time. > > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> > Tested-by: Anand Moon <linux.amoon@gmail.com> > --- > Changelog on V2: > - Fix the #endif location > > board/samsung/common/exynos5-dt.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/board/samsung/common/exynos5-dt.c > b/board/samsung/common/exynos5-dt.c index a4eb351405..862644b00e > 100644 --- a/board/samsung/common/exynos5-dt.c > +++ b/board/samsung/common/exynos5-dt.c > @@ -93,6 +93,9 @@ int exynos_power_init(void) > struct udevice *dev; > int ret; > > +#ifdef CONFIG_PMIC_S2MPS11 > + ret = pmic_get("s2mps11_pmic", &dev); > +#else > ret = pmic_get("max77686", &dev); Cannot this be added to DT? We use #ifdefs in a file, which is supposed to parse DT config. > if (!ret) { > /* TODO(sjg at chromium.org): Move into the clock/pmic > API */ @@ -112,6 +115,7 @@ int exynos_power_init(void) > s5m8767_enable_32khz_cp(dev); > #endif > } > +#endif /* CONFIG_PMIC_S2MPS11 */ > if (ret == -ENODEV) > return 0; > Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180129/66ef2569/attachment.sig> ^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH v2] samsung: board: init the s2mps11 pmic during booting time 2018-01-29 9:12 ` Lukasz Majewski @ 2018-01-30 5:18 ` Jaehoon Chung 0 siblings, 0 replies; 3+ messages in thread From: Jaehoon Chung @ 2018-01-30 5:18 UTC (permalink / raw) To: u-boot On 01/29/2018 06:12 PM, Lukasz Majewski wrote: > Hi Jaehoon, > >> Exynos5422 board has s2mps11 pmic. >> If CONFIG_PMIC_S2MPS11 is enabled, it can initialize PMIC and >> Regulators during booting time. >> >> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> >> Tested-by: Anand Moon <linux.amoon@gmail.com> >> --- >> Changelog on V2: >> - Fix the #endif location >> >> board/samsung/common/exynos5-dt.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/board/samsung/common/exynos5-dt.c >> b/board/samsung/common/exynos5-dt.c index a4eb351405..862644b00e >> 100644 --- a/board/samsung/common/exynos5-dt.c >> +++ b/board/samsung/common/exynos5-dt.c >> @@ -93,6 +93,9 @@ int exynos_power_init(void) >> struct udevice *dev; >> int ret; >> >> +#ifdef CONFIG_PMIC_S2MPS11 >> + ret = pmic_get("s2mps11_pmic", &dev); >> +#else >> ret = pmic_get("max77686", &dev); > > Cannot this be added to DT? We use #ifdefs in a file, which is supposed > to parse DT config. Will do. Best Regards, Jaehoon Chung > >> if (!ret) { >> /* TODO(sjg at chromium.org): Move into the clock/pmic >> API */ @@ -112,6 +115,7 @@ int exynos_power_init(void) >> s5m8767_enable_32khz_cp(dev); >> #endif >> } >> +#endif /* CONFIG_PMIC_S2MPS11 */ >> if (ret == -ENODEV) >> return 0; >> > > > Best regards, > > Lukasz Majewski > > -- > > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-30 5:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20180129045322epcas1p46ad80065361454354b7c5488d67a83d8@epcas1p4.samsung.com>
2018-01-29 4:53 ` [U-Boot] [PATCH v2] samsung: board: init the s2mps11 pmic during booting time Jaehoon Chung
2018-01-29 9:12 ` Lukasz Majewski
2018-01-30 5:18 ` Jaehoon Chung
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox