From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] Kconfig: usb: Sort USB_FUNCTION_* entries
Date: Tue, 30 Jan 2018 10:02:55 +0100 [thread overview]
Message-ID: <20180130100255.4568eef9@jawa> (raw)
In-Reply-To: <CAK7LNAQ9t_RboLS1o+2e6SUSwG=bobVXM+VxDJ2-Qu-K4Rg-zQ@mail.gmail.com>
Hi Masahiro,
> 2018-01-30 3:21 GMT+09:00 Lukasz Majewski <lukma@denx.de>:
> > Lets provide alphabetical order for USB_FUNCTION_* entries of
> > USB_GADGET_DOWNLOAD
> >
> > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > ---
> >
> > drivers/usb/gadget/Kconfig | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)
>
>
> Nit:
>
> I want to see the subject prefix "Kconfig:"
> only for changes in scripts/kconfig/.
>
> This case, "usb:" will be preferred.
>
> For 2/4 and 3/4, too.
I will change the topic when preparing v2.
Thanks.
>
>
>
> > diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> > index c387f5e49792..b1541bb67781 100644
> > --- a/drivers/usb/gadget/Kconfig
> > +++ b/drivers/usb/gadget/Kconfig
> > @@ -127,13 +127,6 @@ config USB_GADGET_DOWNLOAD
> >
> > if USB_GADGET_DOWNLOAD
> >
> > -config USB_FUNCTION_SDP
> > - bool "Enable USB SDP (Serial Download Protocol)"
> > - help
> > - Enable Serial Download Protocol (SDP) device support in
> > U-Boot. This
> > - allows to download images into memory and execute (jump
> > to) them
> > - using the same protocol as implemented by the i.MX
> > family's boot ROM. -
> > config USB_FUNCTION_ROCKUSB
> > bool "Enable USB rockusb gadget"
> > help
> > @@ -142,6 +135,13 @@ config USB_FUNCTION_ROCKUSB
> > the rockusb gadget.for more detail about Rockusb
> > protocol, please see doc/README.rockusb
> >
> > +config USB_FUNCTION_SDP
> > + bool "Enable USB SDP (Serial Download Protocol)"
> > + help
> > + Enable Serial Download Protocol (SDP) device support in
> > U-Boot. This
> > + allows to download images into memory and execute (jump
> > to) them
> > + using the same protocol as implemented by the i.MX
> > family's boot ROM. +
> > endif # USB_GADGET_DOWNLOAD
> >
> > config USB_ETHER
> > --
> > 2.11.0
> >
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot at lists.denx.de
> > https://lists.denx.de/listinfo/u-boot
>
>
>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180130/5c2f4372/attachment.sig>
next prev parent reply other threads:[~2018-01-30 9:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 18:21 [U-Boot] [PATCH 1/4] Kconfig: usb: Sort USB_FUNCTION_* entries Lukasz Majewski
2018-01-30 2:31 ` Masahiro Yamada
2018-01-30 9:02 ` Lukasz Majewski [this message]
2018-02-02 14:34 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130100255.4568eef9@jawa \
--to=lukma@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox