* [U-Boot] [PATCH 1/4] Kconfig: usb: Sort USB_FUNCTION_* entries
@ 2018-01-29 18:21 Lukasz Majewski
2018-01-30 2:31 ` Masahiro Yamada
2018-02-02 14:34 ` [U-Boot] [U-Boot, " Tom Rini
0 siblings, 2 replies; 4+ messages in thread
From: Lukasz Majewski @ 2018-01-29 18:21 UTC (permalink / raw)
To: u-boot
Lets provide alphabetical order for USB_FUNCTION_* entries of
USB_GADGET_DOWNLOAD
Signed-off-by: Lukasz Majewski <lukma@denx.de>
---
drivers/usb/gadget/Kconfig | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
index c387f5e49792..b1541bb67781 100644
--- a/drivers/usb/gadget/Kconfig
+++ b/drivers/usb/gadget/Kconfig
@@ -127,13 +127,6 @@ config USB_GADGET_DOWNLOAD
if USB_GADGET_DOWNLOAD
-config USB_FUNCTION_SDP
- bool "Enable USB SDP (Serial Download Protocol)"
- help
- Enable Serial Download Protocol (SDP) device support in U-Boot. This
- allows to download images into memory and execute (jump to) them
- using the same protocol as implemented by the i.MX family's boot ROM.
-
config USB_FUNCTION_ROCKUSB
bool "Enable USB rockusb gadget"
help
@@ -142,6 +135,13 @@ config USB_FUNCTION_ROCKUSB
the rockusb gadget.for more detail about Rockusb protocol, please see
doc/README.rockusb
+config USB_FUNCTION_SDP
+ bool "Enable USB SDP (Serial Download Protocol)"
+ help
+ Enable Serial Download Protocol (SDP) device support in U-Boot. This
+ allows to download images into memory and execute (jump to) them
+ using the same protocol as implemented by the i.MX family's boot ROM.
+
endif # USB_GADGET_DOWNLOAD
config USB_ETHER
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH 1/4] Kconfig: usb: Sort USB_FUNCTION_* entries
2018-01-29 18:21 [U-Boot] [PATCH 1/4] Kconfig: usb: Sort USB_FUNCTION_* entries Lukasz Majewski
@ 2018-01-30 2:31 ` Masahiro Yamada
2018-01-30 9:02 ` Lukasz Majewski
2018-02-02 14:34 ` [U-Boot] [U-Boot, " Tom Rini
1 sibling, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2018-01-30 2:31 UTC (permalink / raw)
To: u-boot
2018-01-30 3:21 GMT+09:00 Lukasz Majewski <lukma@denx.de>:
> Lets provide alphabetical order for USB_FUNCTION_* entries of
> USB_GADGET_DOWNLOAD
>
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> ---
>
> drivers/usb/gadget/Kconfig | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
Nit:
I want to see the subject prefix "Kconfig:"
only for changes in scripts/kconfig/.
This case, "usb:" will be preferred.
For 2/4 and 3/4, too.
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index c387f5e49792..b1541bb67781 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -127,13 +127,6 @@ config USB_GADGET_DOWNLOAD
>
> if USB_GADGET_DOWNLOAD
>
> -config USB_FUNCTION_SDP
> - bool "Enable USB SDP (Serial Download Protocol)"
> - help
> - Enable Serial Download Protocol (SDP) device support in U-Boot. This
> - allows to download images into memory and execute (jump to) them
> - using the same protocol as implemented by the i.MX family's boot ROM.
> -
> config USB_FUNCTION_ROCKUSB
> bool "Enable USB rockusb gadget"
> help
> @@ -142,6 +135,13 @@ config USB_FUNCTION_ROCKUSB
> the rockusb gadget.for more detail about Rockusb protocol, please see
> doc/README.rockusb
>
> +config USB_FUNCTION_SDP
> + bool "Enable USB SDP (Serial Download Protocol)"
> + help
> + Enable Serial Download Protocol (SDP) device support in U-Boot. This
> + allows to download images into memory and execute (jump to) them
> + using the same protocol as implemented by the i.MX family's boot ROM.
> +
> endif # USB_GADGET_DOWNLOAD
>
> config USB_ETHER
> --
> 2.11.0
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH 1/4] Kconfig: usb: Sort USB_FUNCTION_* entries
2018-01-30 2:31 ` Masahiro Yamada
@ 2018-01-30 9:02 ` Lukasz Majewski
0 siblings, 0 replies; 4+ messages in thread
From: Lukasz Majewski @ 2018-01-30 9:02 UTC (permalink / raw)
To: u-boot
Hi Masahiro,
> 2018-01-30 3:21 GMT+09:00 Lukasz Majewski <lukma@denx.de>:
> > Lets provide alphabetical order for USB_FUNCTION_* entries of
> > USB_GADGET_DOWNLOAD
> >
> > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > ---
> >
> > drivers/usb/gadget/Kconfig | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)
>
>
> Nit:
>
> I want to see the subject prefix "Kconfig:"
> only for changes in scripts/kconfig/.
>
> This case, "usb:" will be preferred.
>
> For 2/4 and 3/4, too.
I will change the topic when preparing v2.
Thanks.
>
>
>
> > diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> > index c387f5e49792..b1541bb67781 100644
> > --- a/drivers/usb/gadget/Kconfig
> > +++ b/drivers/usb/gadget/Kconfig
> > @@ -127,13 +127,6 @@ config USB_GADGET_DOWNLOAD
> >
> > if USB_GADGET_DOWNLOAD
> >
> > -config USB_FUNCTION_SDP
> > - bool "Enable USB SDP (Serial Download Protocol)"
> > - help
> > - Enable Serial Download Protocol (SDP) device support in
> > U-Boot. This
> > - allows to download images into memory and execute (jump
> > to) them
> > - using the same protocol as implemented by the i.MX
> > family's boot ROM. -
> > config USB_FUNCTION_ROCKUSB
> > bool "Enable USB rockusb gadget"
> > help
> > @@ -142,6 +135,13 @@ config USB_FUNCTION_ROCKUSB
> > the rockusb gadget.for more detail about Rockusb
> > protocol, please see doc/README.rockusb
> >
> > +config USB_FUNCTION_SDP
> > + bool "Enable USB SDP (Serial Download Protocol)"
> > + help
> > + Enable Serial Download Protocol (SDP) device support in
> > U-Boot. This
> > + allows to download images into memory and execute (jump
> > to) them
> > + using the same protocol as implemented by the i.MX
> > family's boot ROM. +
> > endif # USB_GADGET_DOWNLOAD
> >
> > config USB_ETHER
> > --
> > 2.11.0
> >
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot at lists.denx.de
> > https://lists.denx.de/listinfo/u-boot
>
>
>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180130/5c2f4372/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [U-Boot, 1/4] Kconfig: usb: Sort USB_FUNCTION_* entries
2018-01-29 18:21 [U-Boot] [PATCH 1/4] Kconfig: usb: Sort USB_FUNCTION_* entries Lukasz Majewski
2018-01-30 2:31 ` Masahiro Yamada
@ 2018-02-02 14:34 ` Tom Rini
1 sibling, 0 replies; 4+ messages in thread
From: Tom Rini @ 2018-02-02 14:34 UTC (permalink / raw)
To: u-boot
On Mon, Jan 29, 2018 at 07:21:39PM +0100, Lukasz Majewski wrote:
> Lets provide alphabetical order for USB_FUNCTION_* entries of
> USB_GADGET_DOWNLOAD
>
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180202/9263d1f2/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-02-02 14:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-29 18:21 [U-Boot] [PATCH 1/4] Kconfig: usb: Sort USB_FUNCTION_* entries Lukasz Majewski
2018-01-30 2:31 ` Masahiro Yamada
2018-01-30 9:02 ` Lukasz Majewski
2018-02-02 14:34 ` [U-Boot] [U-Boot, " Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox