public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ulf Magnusson <ulfalizer@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] x86: kconfig: Remove meaningless 'select n'
Date: Tue, 30 Jan 2018 13:59:03 +0100	[thread overview]
Message-ID: <20180130125903.5920-1-ulfalizer@gmail.com> (raw)

'select n' selects a constant symbol, which is meaningless and has no
effect. Maybe this was meant to be a 'default n', though bool and
tristate symbols already implicitly default to n.

Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib),
which does more strict checking here:

	kconfiglib.KconfigSyntaxError: board/google/Kconfig:34: Couldn't parse '	select n': expected nonconstant symbol

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 board/google/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/board/google/Kconfig b/board/google/Kconfig
index e56c026ef6..766db1b449 100644
--- a/board/google/Kconfig
+++ b/board/google/Kconfig
@@ -31,7 +31,6 @@ config TARGET_CHROMEBOOK_LINK64
 
 config TARGET_CHROMEBOX_PANTHER
 	bool "Chromebox panther (not available)"
-	select n
 	help
 	  Note: At present this must be used with coreboot. See README.x86
 	  for instructions.
-- 
2.14.1

             reply	other threads:[~2018-01-30 12:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-30 12:59 Ulf Magnusson [this message]
2018-01-30 13:04 ` [U-Boot] [PATCH] x86: kconfig: Remove meaningless 'select n' Bin Meng
2018-01-30 14:42   ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180130125903.5920-1-ulfalizer@gmail.com \
    --to=ulfalizer@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox