From: Ulf Magnusson <ulfalizer@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] am335x, shc: kconfig: Fix misspelled choice default
Date: Tue, 30 Jan 2018 14:04:43 +0100 [thread overview]
Message-ID: <20180130130443.6499-1-ulfalizer@gmail.com> (raw)
There is no EMMC symbol in the "enable different boot versions for the
shc board" choice. SHC_EMMC was probably intended.
No functional changes. Kconfig choices fall back on using the first
(visible) symbol in the choice as the default if the default symbol is
not visible.
Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib),
which prints the following warning:
warning: the default selection EMMC (undefined) of <choice> (defined at board/bosch/shc/Kconfig:15) is not contained in the choice
I've added a corresponding warning to the C tools too, which is
currently in linux-next: https://patchwork.kernel.org/patch/9983667/
Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
board/bosch/shc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/bosch/shc/Kconfig b/board/bosch/shc/Kconfig
index c71af11c1c..e0e56e6bfd 100644
--- a/board/bosch/shc/Kconfig
+++ b/board/bosch/shc/Kconfig
@@ -14,7 +14,7 @@ config SYS_CONFIG_NAME
choice
prompt "enable different boot versions for the shc board"
- default EMMC
+ default SHC_EMMC
help
Select the boot version of the shc board.
--
2.14.1
next reply other threads:[~2018-01-30 13:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 13:04 Ulf Magnusson [this message]
2018-02-06 1:58 ` [U-Boot] am335x, shc: kconfig: Fix misspelled choice default Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130130443.6499-1-ulfalizer@gmail.com \
--to=ulfalizer@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox