[U-Boot] [PATCH] am335x, shc: kconfig: Fix misspelled choice default

[U-Boot] [PATCH] am335x, shc: kconfig: Fix misspelled choice default

[Ulf Magnusson]

There is no EMMC symbol in the "enable different boot versions for the
shc board" choice. SHC_EMMC was probably intended.

No functional changes. Kconfig choices fall back on using the first
(visible) symbol in the choice as the default if the default symbol is
not visible.

Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib),
which prints the following warning:

	warning: the default selection EMMC (undefined) of <choice> (defined at board/bosch/shc/Kconfig:15) is not contained in the choice

I've added a corresponding warning to the C tools too, which is
currently in linux-next: https://patchwork.kernel.org/patch/9983667/

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 board/bosch/shc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/bosch/shc/Kconfig b/board/bosch/shc/Kconfig
index c71af11c1c..e0e56e6bfd 100644
--- a/board/bosch/shc/Kconfig
+++ b/board/bosch/shc/Kconfig
@@ -14,7 +14,7 @@ config SYS_CONFIG_NAME
 
 choice
 	prompt "enable different boot versions for the shc board"
-	default EMMC
+	default SHC_EMMC
 	help
 	  Select the boot version of the shc board.
 
-- 
2.14.1

[U-Boot] am335x, shc: kconfig: Fix misspelled choice default

[Tom Rini]

On Tue, Jan 30, 2018 at 02:04:43PM +0100, Ulf Magnusson wrote:

> There is no EMMC symbol in the "enable different boot versions for the
> shc board" choice. SHC_EMMC was probably intended.
> 
> No functional changes. Kconfig choices fall back on using the first
> (visible) symbol in the choice as the default if the default symbol is
> not visible.
> 
> Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib),
> which prints the following warning:
> 
> 	warning: the default selection EMMC (undefined) of <choice> (defined at board/bosch/shc/Kconfig:15) is not contained in the choice
> 
> I've added a corresponding warning to the C tools too, which is
> currently in linux-next: https://patchwork.kernel.org/patch/9983667/
> 
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180205/5b67e465/attachment.sig>