From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v2, 3/4] env: make env drivers propagate env_import return value
Date: Thu, 1 Feb 2018 08:09:16 -0500 [thread overview]
Message-ID: <20180201130916.GI4297@bill-the-cat> (raw)
In-Reply-To: <20180131134713.11566-4-sgoldschmidt@de.pepperl-fuchs.com>
On Wed, Jan 31, 2018 at 02:47:12PM +0100, Simon Goldschmidt wrote:
> For multiple env drivers to correctly implement fallback when
> one environment fails to load (e.g. crc error), the return value
> of env_import has to be propagated by all env driver's load
> function.
>
> Without this change, the first driver that succeeds to load an
> environment with an invalid CRC return 0 (success) and no other
> drivers are checked.
>
> Signed-off-by: Simon Goldschmidt <sgoldschmidt@de.pepperl-fuchs.com>
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180201/ec7ab8be/attachment.sig>
next prev parent reply other threads:[~2018-02-01 13:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 13:47 [U-Boot] [PATCH v2 0/4] env: cleanups after adding multiple envs Simon Goldschmidt
2018-01-31 13:47 ` [U-Boot] [PATCH v2 1/4] env: make env_import(_redund) return 0 on success, not 1 Simon Goldschmidt
2018-01-31 15:38 ` Maxime Ripard
2018-02-01 13:09 ` [U-Boot] [U-Boot, v2, " Tom Rini
2018-01-31 13:47 ` [U-Boot] [PATCH v2 2/4] env: move more common code to env_import_redund Simon Goldschmidt
2018-01-31 15:39 ` Maxime Ripard
2018-02-01 13:09 ` [U-Boot] [U-Boot, v2, " Tom Rini
2018-01-31 13:47 ` [U-Boot] [PATCH v2 3/4] env: make env drivers propagate env_import return value Simon Goldschmidt
2018-01-31 15:40 ` Maxime Ripard
2018-02-01 13:09 ` Tom Rini [this message]
2018-01-31 13:47 ` [U-Boot] [PATCH v2 4/4] env: sf: use env_import_redund to simplify env_sf_load Simon Goldschmidt
2018-01-31 15:40 ` Maxime Ripard
2018-02-01 13:09 ` [U-Boot] [U-Boot, v2, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180201130916.GI4297@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox