From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] Kconfig: gadget: Move CONFIG_USB_FUNCTION_MASS_STORAGE to Kconfig
Date: Thu, 1 Feb 2018 16:00:26 +0100 [thread overview]
Message-ID: <20180201150026.yah2vopf3vv6p4as@flea.lan> (raw)
In-Reply-To: <20180130100850.274c5930@jawa>
On Tue, Jan 30, 2018 at 10:08:50AM +0100, Lukasz Majewski wrote:
> Hi Maxime,
>
> > Hi,
> >
> > On Mon, Jan 29, 2018 at 07:25:54PM +0100, Lukasz Majewski wrote:
> > > This commit moves USB_FUNCTION_MASS_STORAGE config to Kconfig.
> > >
> > > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > > ---
> > >
> > > configs/Bananapi_m2m_defconfig | 1 +
> > > configs/CHIP_pro_defconfig | 1 +
> > > configs/Nintendo_NES_Classic_Edition_defconfig | 1 +
> > > configs/Sinlinx_SinA33_defconfig | 1 +
> >
> > Please make that a default for sunxi instead of crippling our
> > defconfigs.
>
> Could you be more specific here?
Add an equivalent to the
#ifdef CONFIG_USB_MUSB_GADGET
#define CONFIG_USB_FUNCTION_MASS_STORAGE
#endif
That was there before, and isn't there anymore. Something like
default y if ARCH_SUNXI && USB_MUSB_GADGET
> I've used moveconfig.py script to check which board has this define in
> its *.h config file.
> Then, it was moved to proper defconfig for this board.
>
> Hence, I don't understand why I "cripple" your (sunxi) defconfig(s)?
>
> If this is the case - I can "select" this option for all sunxi devices,
> so all of them would have UMS function enabled.
We're always trying to keep the defconfig as free of boilerplate as
possible, since we have so many of them. And people just keep adding
more and more and more boilerplate options, that's all...
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180201/3cedd142/attachment.sig>
next prev parent reply other threads:[~2018-02-01 15:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180129182618epcas2p3213f1c93d03ff601122b6dcda2229694@epcas2p3.samsung.com>
2018-01-29 18:25 ` [U-Boot] [PATCH 3/4] Kconfig: gadget: Move CONFIG_USB_FUNCTION_MASS_STORAGE to Kconfig Lukasz Majewski
2018-01-30 7:45 ` Maxime Ripard
2018-01-30 9:08 ` Lukasz Majewski
2018-02-01 15:00 ` Maxime Ripard [this message]
2018-01-30 9:02 ` Jaehoon Chung
2018-02-02 14:34 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180201150026.yah2vopf3vv6p4as@flea.lan \
--to=maxime.ripard@free-electrons.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox