From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Fri, 2 Feb 2018 23:47:02 +0100 Subject: [U-Boot] [PATCH] dm: serial: Initialize serial console only when it wasn't already configured In-Reply-To: <20180125172440.1720-1-lukma@denx.de> References: <20180125172440.1720-1-lukma@denx.de> Message-ID: <20180202234702.3c211e97@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de Dear All, > It may happen that the MXC serial IP block is performing some ongoing > transmission (started at e.g. board_init()) when the "initr_serial" is > called. > > As a result the serial port IP block is reset, so transmitted data is > corrupted: > > I2C: ready > DRAM: 1 GiB > jSS('HH��SL_SDHC: 04 rev 0x0 > > This patch prevents from this situation, by avoiding > re-initialization of serial IP block (and execution of the same code > twice). > > I2C: ready > DRAM: 1 GiB > ID: unit type 0x4 rev 0x0 > > This patch is a follow up of following discussions: > http://patchwork.ozlabs.org/patch/820824/ > http://patchwork.ozlabs.org/patch/830957/ > > > Signed-off-by: Lukasz Majewski After some excessive testing it turned out that this patch is not behaving as expected. Please drop it. I will find another, better solution for this issue. Sorry for trouble. > > --- > > drivers/serial/serial-uclass.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/serial/serial-uclass.c > b/drivers/serial/serial-uclass.c index 2e5116f7ce..c345578b36 100644 > --- a/drivers/serial/serial-uclass.c > +++ b/drivers/serial/serial-uclass.c > @@ -129,6 +129,9 @@ static void serial_find_console_or_panic(void) > /* Called prior to relocation */ > int serial_init(void) > { > + if (gd->flags & GD_FLG_SERIAL_READY) > + return 0; > + > serial_find_console_or_panic(); > gd->flags |= GD_FLG_SERIAL_READY; > Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: