From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Date: Wed, 7 Feb 2018 18:19:13 +0100 Subject: [U-Boot] [PATCH v4 2/2] Enable test case with A20-OLinuXino-Lime2 In-Reply-To: References: <1517922874-5815-1-git-send-email-stefan@olimex.com> <1517922874-5815-2-git-send-email-stefan@olimex.com> <70ef7ae8-5167-9f63-52a9-7ed080b8b1b5@gmail.com> Message-ID: <20180207171913.uob6sosp6psqbloc@flea> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Feb 07, 2018 at 12:55:54PM +0530, Jagan Teki wrote: > >>>>> +&spi0 { > >>>>> + pinctrl-names = "default"; > >>>>> + pinctrl-0 = <&spi0_pins_b>, <&spi0_cs0_pins_b>; > >>>>> + status = "okay"; > >>>>> + > >>>>> + flash: w25q128 at 0 { > >>>> > >>>> Was it sync from Linux? > >>> > >>> No, this isn't in the linux dts. > >> > >> But we have to, please send it to Linux first. > > > > We've already commented this issue. In the v2 [1], I've explained that this > > won't go mainline, since it's optional feature. Rather it will be managed > > with overlays. > > Thought this was already in ML, and ready to merge. So this never go > to Linux tree since it's optional? then add u-boot.dtsi for this > atleast since we always sync dts from Linux. This is an optional feature on that board. We should be making it as easy as possible to enable it, but a defconfig is a *default* configuration, and if the board doesn't have it by default, it shouldn't be enabled in the defconfig. Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: