[U-Boot] [PATCH v2] spl: eMMC/SD: Provide one __weak spl_boot_mode() function

[Lukasz Majewski <lukma@denx.de>]

Hi Jonathan,

> On Sat, Feb 03, 2018 at 11:00:35AM -0200, Fabio Estevam wrote:
> > On Sat, Feb 3, 2018 at 5:29 AM, Lukasz Majewski <lukma@denx.de>
> > wrote:  
> > > The goal of this patch is to clean up the code related to
> > > choosing SPL MMC boot mode.
> > >
> > > The spl_boot_mode() now is called only in spl_mmc_load_image()
> > > function, which is only compiled in if CONFIG_SPL_MMC_SUPPORT is
> > > enabled.
> > >
> > > To achieve the goal, all per mach/arch implementations eligible
> > > for unification has been replaced with one __weak implementation.
> > >
> > > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > > Reviewed-by: Marek Vasut <marex@denx.de>
> > > Reviewed-by: Stefano Babic <sbabic@denx.de>
> > > Acked-by: Michal Simek <michal.simek@xilinx.com> (For ZynqMP)  
> > 
> > Nice cleanup:
> > 
> > Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>  
> 
> This has broken booting via mmc with mx6cuboxi for me.
> 
> SPL loops on
> 
> U-Boot SPL 2018.03-rc1-00212-g48914fc119 (Feb 10 2018 - 11:04:33
> +1300) Trying to boot from MMC1
> Failed to mount ext2 filesystem...
> spl_load_image_ext: ext4fs mount err - 0

Could you check what is the status of following defines in your .config
file:

CONFIG_SPL_FAT_SUPPORT
CONFIG_SUPPORT_EMMC_BOOT

And if by any chance your don't have:
CONFIG_SPL_EXT_SUPPORT defined?

From what you have written above I assume that you boot from the
same medium - i.e. eMMC (so SPL and u-boot.img are on the same medium) ?


Best regards,
Łukasz Majewski

> 
> There is no ext2/ext3/ext4 fs, next U-Boot stage is raw, ie
> 
> dd if=mx6cuboxi/SPL of=/dev/sd2c bs=1024 seek=1
> dd if=mx6cuboxi/u-boot.img of=/dev/sd2c bs=1024 seek=69
> 
> => part list mmc 0  
> 
> Partition Map for MMC device 0  --   Partition Type: DOS
> 
> Part    Start Sector    Num Sectors     UUID            Type
>   1     2048            32768           00000000-01     0c Boot
>   4     34816           15642624        00000000-04     a6
> 
> With this commit reverted:
> 
> U-Boot SPL 2018.03-rc1-00214-ge3f2485203 (Feb 10 2018 - 12:38:46
> +1300) Trying to boot from MMC1
> 
> 
> U-Boot 2018.03-rc1-00214-ge3f2485203 (Feb 10 2018 - 12:38:46 +1300)
> 
> CPU:   Freescale i.MX6Q rev1.5 996 MHz (running at 792 MHz)
> CPU:   Extended Commercial temperature grade (-20C to 105C) at 27C
> Reset cause: POR
> Board: MX6 Cubox-i
> DRAM:  2 GiB
> MMC:   FSL_SDHC: 0
> Loading Environment from MMC... OK
> No panel detected: default to HDMI
> Display: HDMI (1024x768)
> In:    serial
> Out:   serial
> Err:   serial
> Net:   FEC
> Hit any key to stop autoboot:  0
> switch to partitions #0, OK
> mmc0 is current device
> Scanning mmc 0:1...
> 37503 bytes read in 18 ms (2 MiB/s)
> Found EFI removable media binary efi/boot/bootarm.efi
> Scanning disks on usb...
> Disk usb0 not ready
> Disk usb1 not ready
> Disk usb2 not ready
> Disk usb3 not ready
> Scanning disks on mmc...
> MMC Device 1 not found
> MMC Device 2 not found
> MMC Device 3 not found
> Scanning disks on sata...
> Disk sata0 not ready
> Found 3 disks
> 76528 bytes read in 30 ms (2.4 MiB/s)
> ## Starting EFI application at 12000000 ...
> >> OpenBSD/armv7 BOOTARM 1.0  
> boot>   
> booting sd0a:/bsd: 4531856+203028+560156
> [277405+90+281904+244582]=0x5d6b88




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180210/91a6a8a2/attachment.sig>