[U-Boot] [PATCH 8/8] Migrate generic bootcount to Kconfig

Lukasz Majewski
2018-02-12T10:27:30Z

On Mon, 12 Feb 2018 09:48:13 +0100
Lukasz Majewski <lukma@denx.de> wrote:

> Hi Alex,
>
> > On Sun, Feb 11, 2018 at 9:44 PM, Lukasz Majewski <lukma@denx.de>
> > wrote:
> > > On Sun, 11 Feb 2018 21:04:46 +0000
> > > Alex Kiernan <alex.kiernan@gmail.com> wrote:
> > >
> > >>
> > >> That said, squashing in that change doesn't obviously break
> > >> anything for me, and is probably a step in the right direction.
> > >>
> > >> I'll see what Travis thinks.
> > >>
> > >
> > > We will probably receive build breaks...
> >
> > Yup... https://travis-ci.org/akiernan/u-boot/jobs/340344489
> >
> > Just tried again on one of those failures (x600) with the the
> > default removed and just set the on board that uses CONFIG_EXT, but
> > that then fails at config time.
>
> Ok. I see
>
> >
> > TBH I'd actually like to take it out of Kconfig (which I realise is
> > the wrong direction) as it just feels fundamentally wrong the way it
> > is.
>
> To finish moving SYS_BOOTCOUNT_ADDR to Kconfig we would need to add
> its definition to each eligible ./configs/<board>_defconfig file.
>
> Then we would have the previous behaviour preserved.
>
> > I don't know what the U-Boot approach configuration like this
> > is... struggling to find prior art.

I had similar issue with HW_WATCHDOG conversion:

http://patchwork.ozlabs.org/cover/871576/
especially:

http://patchwork.ozlabs.org/patch/871579/

>
> Let's ask Tom for his opinion as he did much such work before.
>
> >
>
>
> Best regards,
>
> Lukasz Majewski
>
> --
>
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180212/a4d9625c/attachment.sig>