public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 8/8] Migrate generic bootcount to Kconfig
Date: Sun, 11 Feb 2018 20:36:46 +0100	[thread overview]
Message-ID: <20180211203646.24102b36@jawa> (raw)
In-Reply-To: <1518350813-3418-9-git-send-email-alex.kiernan@gmail.com>

Hi Alex,

> Make generate boot counter selected in the same way as other boot
> count drivers
> 
> Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
> ---
> 
>  drivers/bootcount/Kconfig  | 11 +++++++++++
>  drivers/bootcount/Makefile |  2 +-
>  2 files changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/bootcount/Kconfig b/drivers/bootcount/Kconfig
> index e0d1fc2..9fde2f2 100644
> --- a/drivers/bootcount/Kconfig
> +++ b/drivers/bootcount/Kconfig
> @@ -14,6 +14,16 @@ choice
>  	prompt "Boot count device"
>  	default BOOTCOUNT_AM33XX if AM33XX || SOC_DA8XX
>  	default BOOTCOUNT_AT91 if AT91SAM9XE
> +	default BOOTCOUNT_GENERIC
> +
> +config BOOTCOUNT_GENERIC
> +	bool "Generic default boot counter"
> +	help
> +	  Generic bootcount stored at SYS_BOOTCOUNT_ADDR.
> +
> +	  SYS_BOOTCOUNT_ADDR:
> +	    Set to the address where the bootcount and bootcount
> magic
> +	    will be stored.
>  
>  config BOOTCOUNT_EXT
>  	bool "Boot counter on EXT filesystem"
> @@ -64,6 +74,7 @@ endchoice
>  
>  config SYS_BOOTCOUNT_SINGLEWORD
>  	bool "Use single word to pack boot count and magic value"
> +	depends on BOOTCOUNT_GENERIC
>  	help
>  	  This option enables packing boot count magic value and
> boot count into single word (32 bits).
> diff --git a/drivers/bootcount/Makefile b/drivers/bootcount/Makefile
> index a3658c1..3e1ae8c 100644
> --- a/drivers/bootcount/Makefile
> +++ b/drivers/bootcount/Makefile
> @@ -2,7 +2,7 @@
>  # SPDX-License-Identifier:	GPL-2.0+
>  #
>  
> -obj-y				+= bootcount.o
> +obj-$(CONFIG_BOOTCOUNT_GENERIC)	+= bootcount.o
>  obj-$(CONFIG_BOOTCOUNT_AT91)	+= bootcount_at91.o
>  obj-$(CONFIG_BOOTCOUNT_AM33XX)	+= bootcount_davinci.o
>  obj-$(CONFIG_BOOTCOUNT_RAM)	+= bootcount_ram.o

Reviewed-by: Lukasz Majewski <lukma@denx.de>


I had to put attached patch (one liner) to make it working on my setup
(this allows re-using the SYS_BOOTCOUNT_ADDR on non EXT setup).

Could you squash this patch to your work and send v2?

Thanks in advance,

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-bootcount-Kconfig-Enable-CONFIG_SYS_BOOTCOUNT_ADDR-t.patch
Type: text/x-patch
Size: 906 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180211/eae34b25/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180211/eae34b25/attachment.sig>

  reply	other threads:[~2018-02-11 19:36 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1518350813-3418-1-git-send-email-alex.kiernan@gmail.com>
2018-02-11 12:06 ` [U-Boot] [PATCH 1/8] Merge CONFIG_BOOTCOUNT and CONFIG_BOOTCOUNT_LIMIT Alex Kiernan
2018-02-11 19:08   ` Lukasz Majewski
2018-02-16  2:13     ` Heinrich Schuchardt
2018-02-12  7:29   ` [U-Boot] EXT: " Ray, Ian
2018-02-11 12:06 ` [U-Boot] [PATCH 2/8] Prepare for multiple bootcount drivers Alex Kiernan
2018-02-11 19:08   ` Lukasz Majewski
2018-02-11 12:06 ` [U-Boot] [PATCH 3/8] Convert CONFIG_BOOTCOUNT_AM33XX to Kconfig Alex Kiernan
2018-02-11 19:08   ` Lukasz Majewski
2018-02-12  7:58   ` [U-Boot] Antwort: " Hannes Schmelzer
2018-02-11 12:06 ` [U-Boot] [PATCH 4/8] Convert CONFIG_BOOTCOUNT_ENV " Alex Kiernan
2018-02-11 19:09   ` Lukasz Majewski
2018-02-13  9:30   ` Lukasz Majewski
2018-02-13  9:52     ` Alex Kiernan
2018-02-11 12:06 ` [U-Boot] [PATCH 5/8] Convert CONFIG_BOOTCOUNT_RAM " Alex Kiernan
2018-02-11 19:04   ` Lukasz Majewski
2018-02-11 12:06 ` [U-Boot] [PATCH 6/8] Convert CONFIG_BOOTCOUNT_I2C " Alex Kiernan
2018-02-11 19:05   ` Lukasz Majewski
2018-02-11 12:06 ` [U-Boot] [PATCH 7/8] Integrate AT91 bootcount driver Alex Kiernan
2018-02-11 19:05   ` Lukasz Majewski
2018-02-11 12:06 ` [U-Boot] [PATCH 8/8] Migrate generic bootcount to Kconfig Alex Kiernan
2018-02-11 19:36   ` Lukasz Majewski [this message]
2018-02-11 21:04     ` Alex Kiernan
2018-02-11 21:44       ` Lukasz Majewski
2018-02-12  5:55         ` Alex Kiernan
2018-02-12  8:48           ` Lukasz Majewski
2018-02-12 10:27             ` Lukasz Majewski
2018-02-13  9:51             ` Alex Kiernan
2018-02-13 14:41               ` Lukasz Majewski
2018-02-14  6:23                 ` Alex Kiernan
2018-02-14  8:53                   ` Lukasz Majewski
2018-02-14 16:34                     ` Alex Kiernan
2018-02-14 19:13                       ` Lukasz Majewski
2018-02-15 14:04                         ` Alex Kiernan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180211203646.24102b36@jawa \
    --to=lukma@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox