From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/4] Convert socfpga: select CONFIG_HW_WATCHDOG support for ARCH_SOCFPGA
Date: Sun, 11 Feb 2018 19:06:32 -0500 [thread overview]
Message-ID: <20180212000632.GL3061@bill-the-cat> (raw)
In-Reply-To: <20180212003410.384dbbb3@jawa>
On Mon, Feb 12, 2018 at 12:34:10AM +0100, Lukasz Majewski wrote:
> Hi Simon,
>
> > On 09.02.2018 23:14, Lukasz Majewski wrote:
> > > All Socfpga boards from ./include/configs/socfpga_* define
> > > CONFIG_HW_WATCHDOG.
> > > To ease CONFIG_HW_WATCHDOG conversion to Kconfig select it in
> > > config ARCH_SOCFPGA (arch/arm/Kconfig) section.
> >
> > I do have board configs where the internal watchdog is not used and
> > should be disabled (because there's an external one). Also, given
> > that this is an FPGA, I suppose having non-upstreamed boards is not
> > uncommon.
>
> I must admit that this patch I did after looking on the socfpga pattern
> in the current upstream.
>
> It seems like all boards there use HW_WATCHDOG.
>
> >
> > I'm not too familiar with these settings though: can I leave the
> > watchdog disabled when CONFIG_HW_WATCHDOG is off? Before, I just
> > haven't enabled this in my own board config...
>
> I think that I will prepare next revision of this patch with just simple
> ./tools/moveconfig.py output (without blindly selecting HW_WATCHDOG on
> all socfpga devices).
>
> In that way we will preserve the current behaviour.
You should probably use imply for features that are common, but
optional.
--
Tom
next prev parent reply other threads:[~2018-02-12 0:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 22:14 [U-Boot] [PATCH v2 0/4] Convert Watchdog related defines to Kconfig Lukasz Majewski
2018-02-09 22:14 ` [U-Boot] [PATCH v2 1/4] Convert CONFIG_IMX_WATCHDOG to Kconfig and remove HW_WATCHDOG Lukasz Majewski
2018-02-13 5:19 ` Heiko Schocher
2018-02-09 22:14 ` [U-Boot] [PATCH v2 2/4] Convert CONFIG_WATCHDOG_TIMEOUT_MSECS to Kconfig Lukasz Majewski
2018-02-13 5:19 ` Heiko Schocher
2018-02-09 22:14 ` [U-Boot] [PATCH v2 3/4] Convert socfpga: select CONFIG_HW_WATCHDOG support for ARCH_SOCFPGA Lukasz Majewski
2018-02-11 19:18 ` Goldschmidt Simon
2018-02-11 23:34 ` Lukasz Majewski
2018-02-12 0:06 ` Tom Rini [this message]
2018-02-12 9:39 ` Lukasz Majewski
2018-02-13 5:20 ` Heiko Schocher
2018-02-09 22:14 ` [U-Boot] [PATCH v2 4/4] Convert CONFIG_HW_WATCHDOG to Kconfig Lukasz Majewski
2018-02-13 6:26 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180212000632.GL3061@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox