From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 12 Feb 2018 11:53:09 -0500 Subject: [U-Boot] [PATCH] arm: socfpga: use imply instead of select for spi/mmc In-Reply-To: <307782fd-e2dd-8bf6-9147-a860e04e7b47@denx.de> References: <20180212145212.31720-1-sgoldschmidt@de.pepperl-fuchs.com> <20180212164628.GD10592@bill-the-cat> <307782fd-e2dd-8bf6-9147-a860e04e7b47@denx.de> Message-ID: <20180212165309.GE10592@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Feb 12, 2018 at 05:51:08PM +0100, Marek Vasut wrote: > On 02/12/2018 05:46 PM, Tom Rini wrote: > > On Mon, Feb 12, 2018 at 03:54:13PM +0100, Marek Vasut wrote: > >> On 02/12/2018 03:52 PM, Simon Goldschmidt wrote: > >>> In arch/arm/Kconfig, ARCH_SOCFPGA currently selects some > >>> thins for spi flash and mmc that are not required by the hw. > >> > >> things ? > >> > >> what hw, all supported boards you mean ? > >> > >>> Give users more freedom of choice and use imply here instead > >>> of select. > >>> > >>> This should allow disabling spi support completely or using > >>> sd/mmc boot in "raw mode" (no partitions). > >> > >> You can just turn them off in the defconfigs, but I get what you're > >> trying to say. > > > > Well, hold on. If you have select FOO under ARCH_xxx then you > > can't disable it. You have to use imply FOO under ARCH_xxx so that it's > > turned on by default but a board can disable it in their defconfig. > > Thanks! > > The patch is using imply already ... Right. I wasn't clear if you were saying it wasn't needed, or just to re-word things a lot :) -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: