From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Build system: Don't check for CONFIG_SYS_TEXT_BASE being set
Date: Mon, 12 Feb 2018 16:03:56 -0500 [thread overview]
Message-ID: <20180212210356.GJ10592@bill-the-cat> (raw)
In-Reply-To: <CAMo8Bf+7Duz0+sQyHM6tado8N4xjXhwRCpyizK7vkGyeNk7NAw@mail.gmail.com>
On Mon, Feb 12, 2018 at 12:48:02PM -0800, Max Filippov wrote:
> Hello,
>
> On Tue, Jan 30, 2018 at 7:23 AM, Alexey Brodkin
> <Alexey.Brodkin@synopsys.com> wrote:
> > CONFIG_SYS_TEXT_BASE must be set anyways and then it is used in many
> > places in the same Makefile without any checks
>
> Why? xtensa doesn't use any of it.
>
> On Mon, Feb 12, 2018 at 6:23 AM, Tom Rini <trini@konsulko.com> wrote:
> > I'm largely ok with the above, but:
> > - For Xtensa (Max?), CONFIG_SYS_TEXT_ADDR needs to be renamed to
> > CONFIG_SYS_TEXT_BASE there
>
> For xtensa that address is defined as an expression, like
> (CONFIG_SYS_MEMORY_TOP - CONFIG_SYS_MONITOR_LEN),
> and for a single board it may vary with the CPU core on that board.
> If I just do this replacement then linking fails because of this symbolic
> definition:
>
> xtensa-dc233c-elf-ld.bfd --gc-sections -Bstatic
> --no-dynamic-linker -Ttext "(CONFIG_SYS_MEMORY_TOP -
> CONFIG_SYS_MONITOR_LEN)"
> ...
> xtensa-dc233c-elf-ld.bfd: invalid hex number `(CONFIG_SYS_MEMORY_TOP
> - CONFIG_SYS_MONITOR_LEN)'
OK. But are those also really dynamic values? SYS_MEMORY_TOP,
SYS_MONITOR_LEN and SYS_TEXT_ADDR need to be converted to Kconfig, or
removed from CONFIG namespace, whatever makes the most sense. If the
notion of CONFIG_SYS_TEXT_BASE is just pointless to Xtensa, we add them
to the ifneq(...,) test for the change Alexey is doing. Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180212/40a6d8ba/attachment.sig>
next prev parent reply other threads:[~2018-02-12 21:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 15:23 [U-Boot] [PATCH] Build system: Don't check for CONFIG_SYS_TEXT_BASE being set Alexey Brodkin
2018-01-30 16:23 ` Masahiro Yamada
2018-01-30 16:28 ` Alexey Brodkin
2018-01-31 15:18 ` Masahiro Yamada
2018-01-31 15:21 ` Alexey Brodkin
2018-02-02 15:01 ` Masahiro Yamada
2018-02-11 20:47 ` [U-Boot] " Tom Rini
2018-02-12 13:27 ` Alexey Brodkin
2018-02-12 14:23 ` Tom Rini
2018-02-12 14:46 ` Marek Vasut
2018-02-12 16:21 ` Alexey Brodkin
2018-02-12 16:29 ` Tom Rini
2018-02-12 20:48 ` Max Filippov
2018-02-12 21:03 ` Tom Rini [this message]
2018-02-12 21:48 ` Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180212210356.GJ10592@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox