public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] arm: socfpga: use imply instead of select where applicable
Date: Tue, 13 Feb 2018 09:38:10 +0100	[thread overview]
Message-ID: <20180213093810.1d4af14f@jawa> (raw)
In-Reply-To: <20180213053414.5195-3-sgoldschmidt@de.pepperl-fuchs.com>

On Tue, 13 Feb 2018 06:34:14 +0100
Simon Goldschmidt <sgoldschmidt@de.pepperl-fuchs.com> wrote:

> Kconfig should only 'select' features that are required for an arch.
> Standard features that can be disabled without breaking board support
> should use 'imply' instead, to allow users to disable it.
> 
> These options are changed for mach-socfpga:
> - DM_SPI & DM_SPI_FLASH: only required with QSPI support enabled
> - SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION: the boot rom supports a
>   partitionless mode also, where SPL is located at address 0
> - HW_WATCHDOG: while all mainline board defconfigs use it, U-Boot
>   should still work without it.
> 
> Signed-off-by: Simon Goldschmidt <sgoldschmidt@de.pepperl-fuchs.com>
> ---
> 
>  arch/arm/Kconfig | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index b4c79d6499..5edd67c471 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -699,17 +699,17 @@ config ARCH_SOCFPGA
>  	select OF_CONTROL
>  	select SPL_OF_CONTROL
>  	select DM
> -	select DM_SPI_FLASH
> -	select DM_SPI
>  	select ENABLE_ARM_SOC_BOOT0_HOOK
> -	select HW_WATCHDOG
>  	select ARCH_EARLY_INIT_R
>  	select ARCH_MISC_INIT
> -	select SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION
>  	select SYS_THUMB_BUILD
>  	imply CMD_MTDPARTS
>  	imply CRC32_VERIFY
> +	imply DM_SPI
> +	imply DM_SPI_FLASH
>  	imply FAT_WRITE
> +	imply HW_WATCHDOG
> +	imply SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION
>  
>  config ARCH_SUNXI
>  	bool "Support sunxi (Allwinner) SoCs"

Reviewed-by: Lukasz Majewski <lukma@denx.de>


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180213/daa7a33a/attachment.sig>

  reply	other threads:[~2018-02-13  8:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-13  5:34 [U-Boot] [PATCH 0/2] arm: socfpga: Kconfig cleanups Simon Goldschmidt
2018-02-13  5:34 ` [U-Boot] [PATCH 1/2] Convert socfpga: select CONFIG_HW_WATCHDOG support for ARCH_SOCFPGA Simon Goldschmidt
2018-02-13  5:34 ` [U-Boot] [PATCH 2/2] arm: socfpga: use imply instead of select where applicable Simon Goldschmidt
2018-02-13  8:38   ` Lukasz Majewski [this message]
2018-02-13  8:39 ` [U-Boot] [PATCH 0/2] arm: socfpga: Kconfig cleanups Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180213093810.1d4af14f@jawa \
    --to=lukma@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox