From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Tue, 13 Feb 2018 22:27:55 +0100 Subject: [U-Boot] [PATCH 1/1] fs: fat: avoid superfluous conversion calling set_cluster In-Reply-To: <20180213182329.11684-1-xypron.glpk@gmx.de> References: <20180213182329.11684-1-xypron.glpk@gmx.de> Message-ID: <20180213222755.4755203c@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, 13 Feb 2018 19:23:29 +0100 Heinrich Schuchardt wrote: > Parameter size of function set_cluster is of type unsigned long. It > makes no sense to convert actsize to int before passing it to > set_cluster as size. > > Signed-off-by: Heinrich Schuchardt > --- > fs/fat/fat_write.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/fs/fat/fat_write.c b/fs/fat/fat_write.c > index 2b753df2820..ccc03cecb6e 100644 > --- a/fs/fat/fat_write.c > +++ b/fs/fat/fat_write.c > @@ -679,7 +679,8 @@ set_contents(fsdata *mydata, dir_entry *dentptr, > __u8 *buffer, > /* set remaining bytes */ > actsize = filesize; > - if (set_cluster(mydata, curclust, buffer, > (int)actsize) != 0) { > + if (set_cluster(mydata, curclust, buffer, > + (unsigned long)actsize) != 0) { > debug("error: writing cluster\n"); > return -1; > } > @@ -696,7 +697,8 @@ set_contents(fsdata *mydata, dir_entry *dentptr, > __u8 *buffer, > return 0; > getit: > - if (set_cluster(mydata, curclust, buffer, > (int)actsize) != 0) { > + if (set_cluster(mydata, curclust, buffer, > + (unsigned long)actsize) != 0) { > debug("error: writing cluster\n"); > return -1; > } Reviewed-by: Lukasz Majewski Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: