From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] dfu: Limit dfu_mmc to non-SPL case
Date: Wed, 14 Feb 2018 09:34:03 -0500 [thread overview]
Message-ID: <20180214143403.GA10592@bill-the-cat> (raw)
In-Reply-To: <1518618586-26333-1-git-send-email-faiz_abbas@ti.com>
On Wed, Feb 14, 2018 at 07:59:46PM +0530, Faiz Abbas wrote:
> Since 82b9dc63 ("Only build cli_readline.o for CMDLINE on non-SPL"),
> cli_simple.c is only being built for non-SPL case. However, dfu_mmc
> requires cli_simple.c to build and dfu fails to build for SPL when
> CONFIG_HUSH_PARSER is disabled.
>
> Therefore, limit dfu_mmc to non-SPL case only.
>
> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
> ---
> drivers/dfu/Makefile | 2 ++
> drivers/dfu/dfu.c | 2 ++
> 2 files changed, 4 insertions(+)
Does DFU for MMC make sense inside of SPL? If so, you should follow
82b9dc63 and CONFIG_FSL_DDR_INTERACTIVE and bring back in cli_simple.o
(and cli_readline.o, if needed) for CONFIG_SPL_DFU_MMC or so. If not,
we should more cleanly and clearly block out all non-DFU RAM cases for
SPL. Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180214/f891fac4/attachment.sig>
next prev parent reply other threads:[~2018-02-14 14:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 14:29 [U-Boot] [PATCH] dfu: Limit dfu_mmc to non-SPL case Faiz Abbas
2018-02-14 14:34 ` Tom Rini [this message]
2018-02-14 14:45 ` Faiz Abbas
2018-02-14 15:35 ` Tom Rini
2018-02-14 15:36 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214143403.GA10592@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox