From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 14 Feb 2018 09:34:03 -0500 Subject: [U-Boot] [PATCH] dfu: Limit dfu_mmc to non-SPL case In-Reply-To: <1518618586-26333-1-git-send-email-faiz_abbas@ti.com> References: <1518618586-26333-1-git-send-email-faiz_abbas@ti.com> Message-ID: <20180214143403.GA10592@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Feb 14, 2018 at 07:59:46PM +0530, Faiz Abbas wrote: > Since 82b9dc63 ("Only build cli_readline.o for CMDLINE on non-SPL"), > cli_simple.c is only being built for non-SPL case. However, dfu_mmc > requires cli_simple.c to build and dfu fails to build for SPL when > CONFIG_HUSH_PARSER is disabled. > > Therefore, limit dfu_mmc to non-SPL case only. > > Signed-off-by: Faiz Abbas > --- > drivers/dfu/Makefile | 2 ++ > drivers/dfu/dfu.c | 2 ++ > 2 files changed, 4 insertions(+) Does DFU for MMC make sense inside of SPL? If so, you should follow 82b9dc63 and CONFIG_FSL_DDR_INTERACTIVE and bring back in cli_simple.o (and cli_readline.o, if needed) for CONFIG_SPL_DFU_MMC or so. If not, we should more cleanly and clearly block out all non-DFU RAM cases for SPL. Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: