From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Thu, 15 Feb 2018 09:44:03 -0500 Subject: [U-Boot] [PATCH v2] Revert "spl: eMMC/SD: Provide one __weak spl_boot_mode() function" In-Reply-To: <20180215153329.466691e3@jawa> References: <1518696884-15642-1-git-send-email-fabio.estevam@nxp.com> <20180215153329.466691e3@jawa> Message-ID: <20180215144403.GJ10592@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Feb 15, 2018 at 03:33:29PM +0100, Lukasz Majewski wrote: > Hi Fabio, > > > This reverts commit d695d6627803dbb78a226e04b0436a01633a9936. > > > > Commit d695d6627803 ("spl: eMMC/SD: Provide one __weak spl_boot_mode() > > function") breaks the boot on several i.MX6 boards, > > such as cuboxi and wandboard: > > > > U-Boot SPL 2018.03-rc1-00212-g48914fc119 (Feb 10 2018 - 11:04:33 > > +1300) Trying to boot from MMC1 > > Failed to mount ext2 filesystem... > > spl_load_image_ext: ext4fs mount err - 0 > > > > Revert it so that we can boot U-Boot again. > > This is IMHO throwing the baby with the batch.... I kind of feel we need to revert this too, sorry. I'm also worried that we've broken some of the other platforms that also have funky if-else expected logic, and we'll be at the point soon where we have enough platforms that need to override the spl_boot_mode func with what they had before that it's not a huge win. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: