public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 12/13] Migrate CONFIG_BOOTCOUNT_ALEN to Kconfig
Date: Fri, 16 Feb 2018 10:36:06 +0100	[thread overview]
Message-ID: <20180216103606.368ce9d1@jawa> (raw)
In-Reply-To: <1518702926-18874-13-git-send-email-alex.kiernan@gmail.com>

Hi Alex,

Please add at least one sentence to the commit message (not only the
topic).


A side note - I did not received patch 13/13,

It can be found here:
http://patchwork.ozlabs.org/patch/873845/

It is also Ok (as I forgotten to remove SINGLEWORD from whitelist)..

Above patches seems to be eligible to current mailing (rc2+).

The BOOTCOUNT_ADDR conversion would need to wait for merge window, IMHO.

Thanks for your effort,

Best regards,
Łukasz

> Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
> ---
> 
> Changes in v2: None
> 
>  drivers/bootcount/Kconfig    | 9 ++++++++-
>  include/configs/ids8313.h    | 1 -
>  scripts/config_whitelist.txt | 1 -
>  3 files changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/bootcount/Kconfig b/drivers/bootcount/Kconfig
> index ce26e38..1a037f2 100644
> --- a/drivers/bootcount/Kconfig
> +++ b/drivers/bootcount/Kconfig
> @@ -66,7 +66,14 @@ config BOOTCOUNT_I2C
>  	  Enable support for the bootcounter on an i2c (like RTC)
> device. CONFIG_SYS_I2C_RTC_ADDR = i2c chip address
>  	  BOOTCOUNT_ADDR = i2c addr which is used for the
> bootcounter.
> -	  CONFIG_BOOTCOUNT_ALEN = address len
> +
> +config BOOTCOUNT_ALEN
> +	int "I2C address length"
> +	default 1
> +	depends on BOOTCOUNT_I2C
> +	help
> +	  Length of the the I2C address at BOOTCOUNT_ADDR for storing
> +	  the boot counter.
>  
>  config BOOTCOUNT_AT91
>  	bool "Boot counter for Atmel AT91SAM9XE"
> diff --git a/include/configs/ids8313.h b/include/configs/ids8313.h
> index 4449e27..fb891a3 100644
> --- a/include/configs/ids8313.h
> +++ b/include/configs/ids8313.h
> @@ -515,7 +515,6 @@
>  #define CONFIG_MTD_PARTITIONS
>  
>  /* bootcount support */
> -#define CONFIG_BOOTCOUNT_ALEN	1
>  #define BOOTCOUNT_ADDR	0x9
>  
>  #define CONFIG_IMAGE_FORMAT_LEGACY
> diff --git a/scripts/config_whitelist.txt
> b/scripts/config_whitelist.txt index a8380c6..e16085b 100644
> --- a/scripts/config_whitelist.txt
> +++ b/scripts/config_whitelist.txt
> @@ -147,7 +147,6 @@ CONFIG_BOARD_TYPES
>  CONFIG_BOOGER
>  CONFIG_BOOM
>  CONFIG_BOOTBLOCK
> -CONFIG_BOOTCOUNT_ALEN
>  CONFIG_BOOTFILE
>  CONFIG_BOOTMAPSZ
>  CONFIG_BOOTMODE




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180216/3bd3a918/attachment.sig>

  reply	other threads:[~2018-02-16  9:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-15 13:55 [U-Boot] [PATCH v2 00/13] Convert bootcount drivers to Kconfig Alex Kiernan
2018-02-15 13:55 ` [U-Boot] [PATCH v2 01/13] Merge CONFIG_BOOTCOUNT and CONFIG_BOOTCOUNT_LIMIT Alex Kiernan
2018-02-16  9:14   ` Lukasz Majewski
2018-02-15 13:55 ` [U-Boot] [PATCH v2 02/13] Prepare for multiple bootcount drivers Alex Kiernan
2018-02-15 13:55 ` [U-Boot] [PATCH v2 03/13] Convert CONFIG_BOOTCOUNT_AM33XX to Kconfig Alex Kiernan
2018-02-15 13:55 ` [U-Boot] [PATCH v2 04/13] Convert CONFIG_BOOTCOUNT_ENV " Alex Kiernan
2018-02-15 13:55 ` [U-Boot] [PATCH v2 05/13] Convert CONFIG_BOOTCOUNT_RAM " Alex Kiernan
2018-02-15 13:55 ` [U-Boot] [PATCH v2 06/13] Convert CONFIG_BOOTCOUNT_I2C " Alex Kiernan
2018-02-15 13:55 ` [U-Boot] [PATCH v2 07/13] Convert CONFIG_BOOTCOUNT_EXT " Alex Kiernan
2018-02-15 13:55 ` [U-Boot] [PATCH v2 08/13] Integrate AT91 bootcount driver Alex Kiernan
2018-02-15 13:55 ` [U-Boot] [PATCH v2 09/13] Migrate generic bootcount to Kconfig Alex Kiernan
2018-02-15 13:55 ` [U-Boot] [PATCH v2 10/13] Remove SYS_BOOTCOUNT_ADDR from Kconfig Alex Kiernan
2018-02-16  9:19   ` Lukasz Majewski
2018-02-15 13:55 ` [U-Boot] [PATCH v2 11/13] Rename CONFIG_SYS_BOOTCOUNT_ADDR to BOOTCOUNT_ADDR Alex Kiernan
2018-02-16  9:31   ` Lukasz Majewski
2018-02-16  9:46     ` Alex Kiernan
2018-02-15 13:55 ` [U-Boot] [PATCH v2 12/13] Migrate CONFIG_BOOTCOUNT_ALEN to Kconfig Alex Kiernan
2018-02-16  9:36   ` Lukasz Majewski [this message]
2018-02-16  9:43     ` Alex Kiernan
2018-02-15 13:55 ` [U-Boot] [PATCH v2 13/13] Remove CONFIG_SYS_BOOTCOUNT_SINGLEWORD Alex Kiernan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180216103606.368ce9d1@jawa \
    --to=lukma@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox