From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] config_whitelist: remove false-positive CONFIG options
Date: Wed, 21 Feb 2018 07:46:50 -0500 [thread overview]
Message-ID: <20180221124650.GG4311@bill-the-cat> (raw)
In-Reply-To: <CAK7LNAQjC88uAcrTOhV_ROJu4P6pqWCN2LpR08KwNyPk-H9w+Q@mail.gmail.com>
On Wed, Feb 21, 2018 at 09:41:10PM +0900, Masahiro Yamada wrote:
> 2018-02-21 21:19 GMT+09:00 Tom Rini <trini@konsulko.com>:
> > On Wed, Feb 21, 2018 at 04:07:10PM +0900, Masahiro Yamada wrote:
> >> 2018-01-06 3:17 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> >> > U-Boot pulled in several core makefiles from Linux. The following
> >> > are not used in U-Boot:
> >> >
> >> > - CONFIG_DEBUG_SECTION_MISMATCH
> >> > - CONFIG_FTRACE_MCOUNT_RECORD
> >> > - CONFIG_GCOV_KERNEL
> >> > - CONFIG_GCOV_PROFILE_ALL
> >> > - CONFIG_KASAN
> >> > - CONFIG_MODVERSIONS
> >> >
> >> > We can remove the unused code if we like. (although it will get the
> >> > scripts out of sync)
> >> >
> >> > CONFIG_BOOM and CONFIG_HIS_DRIVER are just mentioned in the comment
> >> > block of scripts/basic/fixdep.c
> >> >
> >> > CONFIG_SHELL is not configuration, but a variable for internal-use.
> >> > It is just a historical misnomer in Kbuild.
> >> >
> >> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> >>
> >>
> >> Tom,
> >>
> >> Can you check this please?
> >
> > The problem is that it will get put back in by
> > ./scripts/build-whitelist.sh yes?
>
> No.
>
> If you incrementally run build-whitelist.sh,
> they will not get back.
>
>
> If you delete config_whitelist.txt and
> build it from scratch, yes, they will get back
> with other options we had already deleted.
>
> For example, commit 8bb0f7c0c59e8c5b6f7a6869b802f593739c7ece
>
> But we do not want to do this.
>
>
>
> For detailed implementation, see below.
>
> https://github.com/u-boot/u-boot/blob/v2018.03-rc3/scripts/build-whitelist.sh#L50
Ah, ok, thanks. Yes, I'll grab this soon.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180221/9d5ca6fd/attachment.sig>
next prev parent reply other threads:[~2018-02-21 12:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 18:17 [U-Boot] [PATCH] config_whitelist: remove false-positive CONFIG options Masahiro Yamada
2018-01-08 4:52 ` Simon Glass
2018-02-21 7:07 ` Masahiro Yamada
2018-02-21 12:19 ` Tom Rini
2018-02-21 12:41 ` Masahiro Yamada
2018-02-21 12:46 ` Tom Rini [this message]
2018-02-23 18:03 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180221124650.GG4311@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox