U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 3/4] mmc: omap_hsmmc: compile out ADMA support for am33xx and omap34xx
Date: Thu, 22 Feb 2018 10:47:23 -0500	[thread overview]
Message-ID: <20180222154723.GU4311@bill-the-cat> (raw)
In-Reply-To: <1519295148-6817-4-git-send-email-jjhiblot@ti.com>

On Thu, Feb 22, 2018 at 11:25:47AM +0100, Jean-Jacques Hiblot wrote:
> This reduces the size of the binary by about 600 bytes.
> 
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> ---
> 
>  drivers/mmc/omap_hsmmc.c | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/mmc/omap_hsmmc.c b/drivers/mmc/omap_hsmmc.c
> index 8b57edc..31c1f66 100644
> --- a/drivers/mmc/omap_hsmmc.c
> +++ b/drivers/mmc/omap_hsmmc.c
> @@ -48,6 +48,10 @@
>  #include <dm.h>
>  #include <power/regulator.h>
>  
> +#if !defined(CONFIG_AM33XX) && !defined(CONFIG_OMAP34XX)
> +#define ADMA_SUPPORT
> +#endif
> +
>  DECLARE_GLOBAL_DATA_PTR;
>  
>  /* simplify defines to OMAP_HSMMC_USE_GPIO */
> @@ -93,7 +97,7 @@ struct omap_hsmmc_data {
>  	enum bus_mode mode;
>  #endif
>  	u8 controller_flags;
> -#ifndef CONFIG_OMAP34XX
> +#ifdef ADMA_SUPPORT

How about we add CONFIG_MMC_OMAP_HS_ADMA, and select it on !AM33XX &&
!OMAP34XX, and then test that here?  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180222/e9e731b1/attachment.sig>

  reply	other threads:[~2018-02-22 15:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-22 10:25 [U-Boot] [PATCH v1 0/4] mmc: omap_hsmmc: Reduce the footprint of the driver and fix am335x clock Jean-Jacques Hiblot
2018-02-22 10:25 ` [U-Boot] [PATCH v1 1/4] mmc: omap_hsmmc: do not embed struct mmc in struct omap_hsmmc_plat Jean-Jacques Hiblot
2018-02-22 15:47   ` Tom Rini
2018-02-23 20:59   ` Simon Glass
2018-02-26 10:24     ` Jean-Jacques Hiblot
2018-02-22 10:25 ` [U-Boot] [PATCH v1 2/4] mmc: omap_hsmmc: compile out write support if not needed Jean-Jacques Hiblot
2018-02-22 15:47   ` Tom Rini
2018-02-22 10:25 ` [U-Boot] [PATCH v1 3/4] mmc: omap_hsmmc: compile out ADMA support for am33xx and omap34xx Jean-Jacques Hiblot
2018-02-22 15:47   ` Tom Rini [this message]
2018-02-23  7:06     ` Jaehoon Chung
2018-02-22 10:25 ` [U-Boot] [PATCH v1 4/4] mmc: omap_hsmmc: use a default 52MHz max clock rate if none is specified Jean-Jacques Hiblot
2018-02-22 15:47   ` Tom Rini
2018-02-22 23:09 ` [U-Boot] [PATCH v1 0/4] mmc: omap_hsmmc: Reduce the footprint of the driver and fix am335x clock Adam Ford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180222154723.GU4311@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox