public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 1/2] Makefile: add u-boot-spl.srec target
@ 2018-02-26 19:25 Marek Vasut
  2018-02-26 19:25 ` [U-Boot] [PATCH 2/2] ARM: rmobile: Build u-boot-spl.srec on Gen2 Marek Vasut
  2018-02-26 19:59 ` [U-Boot] [PATCH 1/2] Makefile: add u-boot-spl.srec target Tom Rini
  0 siblings, 2 replies; 7+ messages in thread
From: Marek Vasut @ 2018-02-26 19:25 UTC (permalink / raw)
  To: u-boot

The u-boot-spl.srec is needed for some platforms, add target to generate this file.

Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
Cc: Tom Rini <trini@konsulko.com>
---
 Makefile | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Makefile b/Makefile
index 57cb4b87d9..a3ce04947a 100644
--- a/Makefile
+++ b/Makefile
@@ -926,6 +926,11 @@ OBJCOPYFLAGS_u-boot.srec := -O srec
 u-boot.hex u-boot.srec: u-boot FORCE
 	$(call if_changed,objcopy)
 
+OBJCOPYFLAGS_u-boot-spl.srec = $(OBJCOPYFLAGS_u-boot.srec)
+
+spl/u-boot-spl.srec: spl/u-boot-spl FORCE
+	$(call if_changed,objcopy)
+
 OBJCOPYFLAGS_u-boot-nodtb.bin := -O binary \
 		$(if $(CONFIG_X86_16BIT_INIT),-R .start16 -R .resetvec)
 
-- 
2.16.1

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 2/2] ARM: rmobile: Build u-boot-spl.srec on Gen2
  2018-02-26 19:25 [U-Boot] [PATCH 1/2] Makefile: add u-boot-spl.srec target Marek Vasut
@ 2018-02-26 19:25 ` Marek Vasut
  2018-02-26 20:00   ` Tom Rini
  2018-02-26 19:59 ` [U-Boot] [PATCH 1/2] Makefile: add u-boot-spl.srec target Tom Rini
  1 sibling, 1 reply; 7+ messages in thread
From: Marek Vasut @ 2018-02-26 19:25 UTC (permalink / raw)
  To: u-boot

The u-boot-spl.srec is needed for the minimon update on Gen2 SoCs,
conveniently generate this file if SPL is enabled.

Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
Cc: Tom Rini <trini@konsulko.com>
---
 include/configs/rcar-gen2-common.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/include/configs/rcar-gen2-common.h b/include/configs/rcar-gen2-common.h
index 1ceee9a429..6069220406 100644
--- a/include/configs/rcar-gen2-common.h
+++ b/include/configs/rcar-gen2-common.h
@@ -15,6 +15,10 @@
 #define CONFIG_SETUP_MEMORY_TAGS
 #define CONFIG_INITRD_TAG
 
+#ifdef CONFIG_SPL
+#define CONFIG_SPL_TARGET	"spl/u-boot-spl.srec"
+#endif
+
 #undef	CONFIG_SHOW_BOOT_PROGRESS
 
 #define CONFIG_ARCH_CPU_INIT
-- 
2.16.1

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 1/2] Makefile: add u-boot-spl.srec target
  2018-02-26 19:25 [U-Boot] [PATCH 1/2] Makefile: add u-boot-spl.srec target Marek Vasut
  2018-02-26 19:25 ` [U-Boot] [PATCH 2/2] ARM: rmobile: Build u-boot-spl.srec on Gen2 Marek Vasut
@ 2018-02-26 19:59 ` Tom Rini
  1 sibling, 0 replies; 7+ messages in thread
From: Tom Rini @ 2018-02-26 19:59 UTC (permalink / raw)
  To: u-boot

On Mon, Feb 26, 2018 at 08:25:35PM +0100, Marek Vasut wrote:

> The u-boot-spl.srec is needed for some platforms, add target to generate this file.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> Cc: Tom Rini <trini@konsulko.com>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180226/7b2ed351/attachment.sig>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 2/2] ARM: rmobile: Build u-boot-spl.srec on Gen2
  2018-02-26 19:25 ` [U-Boot] [PATCH 2/2] ARM: rmobile: Build u-boot-spl.srec on Gen2 Marek Vasut
@ 2018-02-26 20:00   ` Tom Rini
  2018-02-26 20:50     ` Marek Vasut
  0 siblings, 1 reply; 7+ messages in thread
From: Tom Rini @ 2018-02-26 20:00 UTC (permalink / raw)
  To: u-boot

On Mon, Feb 26, 2018 at 08:25:36PM +0100, Marek Vasut wrote:

> The u-boot-spl.srec is needed for the minimon update on Gen2 SoCs,
> conveniently generate this file if SPL is enabled.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> Cc: Tom Rini <trini@konsulko.com>
> ---
>  include/configs/rcar-gen2-common.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/configs/rcar-gen2-common.h b/include/configs/rcar-gen2-common.h
> index 1ceee9a429..6069220406 100644
> --- a/include/configs/rcar-gen2-common.h
> +++ b/include/configs/rcar-gen2-common.h
> @@ -15,6 +15,10 @@
>  #define CONFIG_SETUP_MEMORY_TAGS
>  #define CONFIG_INITRD_TAG
>  
> +#ifdef CONFIG_SPL
> +#define CONFIG_SPL_TARGET	"spl/u-boot-spl.srec"
> +#endif
> +
>  #undef	CONFIG_SHOW_BOOT_PROGRESS
>  
>  #define CONFIG_ARCH_CPU_INIT

Can you please convert CONFIG_SPL_TARGET to CONFIG_SPL_BUILD_TARGET, to
match CONFIG_BUILD_TARGET and migrate it after CONFIG_BUILD_TARGET?
Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180226/2c273c13/attachment.sig>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 2/2] ARM: rmobile: Build u-boot-spl.srec on Gen2
  2018-02-26 20:00   ` Tom Rini
@ 2018-02-26 20:50     ` Marek Vasut
  2018-02-27  0:00       ` Tom Rini
  0 siblings, 1 reply; 7+ messages in thread
From: Marek Vasut @ 2018-02-26 20:50 UTC (permalink / raw)
  To: u-boot

On 02/26/2018 09:00 PM, Tom Rini wrote:
> On Mon, Feb 26, 2018 at 08:25:36PM +0100, Marek Vasut wrote:
> 
>> The u-boot-spl.srec is needed for the minimon update on Gen2 SoCs,
>> conveniently generate this file if SPL is enabled.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
>> Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
>> Cc: Tom Rini <trini@konsulko.com>
>> ---
>>  include/configs/rcar-gen2-common.h | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/include/configs/rcar-gen2-common.h b/include/configs/rcar-gen2-common.h
>> index 1ceee9a429..6069220406 100644
>> --- a/include/configs/rcar-gen2-common.h
>> +++ b/include/configs/rcar-gen2-common.h
>> @@ -15,6 +15,10 @@
>>  #define CONFIG_SETUP_MEMORY_TAGS
>>  #define CONFIG_INITRD_TAG
>>  
>> +#ifdef CONFIG_SPL
>> +#define CONFIG_SPL_TARGET	"spl/u-boot-spl.srec"
>> +#endif
>> +
>>  #undef	CONFIG_SHOW_BOOT_PROGRESS
>>  
>>  #define CONFIG_ARCH_CPU_INIT
> 
> Can you please convert CONFIG_SPL_TARGET to CONFIG_SPL_BUILD_TARGET, to
> match CONFIG_BUILD_TARGET and migrate it after CONFIG_BUILD_TARGET?
> Thanks!
> 
Yeah, after the release. I dont plan to mess with it before the release.
Or are you planning to convert BUILD_TARGET to Kconfig _before_ ?

-- 
Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 2/2] ARM: rmobile: Build u-boot-spl.srec on Gen2
  2018-02-26 20:50     ` Marek Vasut
@ 2018-02-27  0:00       ` Tom Rini
  2018-02-27 19:40         ` Marek Vasut
  0 siblings, 1 reply; 7+ messages in thread
From: Tom Rini @ 2018-02-27  0:00 UTC (permalink / raw)
  To: u-boot

On Mon, Feb 26, 2018 at 09:50:44PM +0100, Marek Vasut wrote:
> On 02/26/2018 09:00 PM, Tom Rini wrote:
> > On Mon, Feb 26, 2018 at 08:25:36PM +0100, Marek Vasut wrote:
> > 
> >> The u-boot-spl.srec is needed for the minimon update on Gen2 SoCs,
> >> conveniently generate this file if SPL is enabled.
> >>
> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> >> Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> >> Cc: Tom Rini <trini@konsulko.com>
> >> ---
> >>  include/configs/rcar-gen2-common.h | 4 ++++
> >>  1 file changed, 4 insertions(+)
> >>
> >> diff --git a/include/configs/rcar-gen2-common.h b/include/configs/rcar-gen2-common.h
> >> index 1ceee9a429..6069220406 100644
> >> --- a/include/configs/rcar-gen2-common.h
> >> +++ b/include/configs/rcar-gen2-common.h
> >> @@ -15,6 +15,10 @@
> >>  #define CONFIG_SETUP_MEMORY_TAGS
> >>  #define CONFIG_INITRD_TAG
> >>  
> >> +#ifdef CONFIG_SPL
> >> +#define CONFIG_SPL_TARGET	"spl/u-boot-spl.srec"
> >> +#endif
> >> +
> >>  #undef	CONFIG_SHOW_BOOT_PROGRESS
> >>  
> >>  #define CONFIG_ARCH_CPU_INIT
> > 
> > Can you please convert CONFIG_SPL_TARGET to CONFIG_SPL_BUILD_TARGET, to
> > match CONFIG_BUILD_TARGET and migrate it after CONFIG_BUILD_TARGET?
> > Thanks!
> 
> Yeah, after the release. I dont plan to mess with it before the release.
> Or are you planning to convert BUILD_TARGET to Kconfig _before_ ?

I would be happy enough to take both of those at this point, yes, as
they can be easily verified.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180226/cc4af432/attachment.sig>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 2/2] ARM: rmobile: Build u-boot-spl.srec on Gen2
  2018-02-27  0:00       ` Tom Rini
@ 2018-02-27 19:40         ` Marek Vasut
  0 siblings, 0 replies; 7+ messages in thread
From: Marek Vasut @ 2018-02-27 19:40 UTC (permalink / raw)
  To: u-boot

On 02/27/2018 01:00 AM, Tom Rini wrote:
> On Mon, Feb 26, 2018 at 09:50:44PM +0100, Marek Vasut wrote:
>> On 02/26/2018 09:00 PM, Tom Rini wrote:
>>> On Mon, Feb 26, 2018 at 08:25:36PM +0100, Marek Vasut wrote:
>>>
>>>> The u-boot-spl.srec is needed for the minimon update on Gen2 SoCs,
>>>> conveniently generate this file if SPL is enabled.
>>>>
>>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
>>>> Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
>>>> Cc: Tom Rini <trini@konsulko.com>
>>>> ---
>>>>  include/configs/rcar-gen2-common.h | 4 ++++
>>>>  1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/include/configs/rcar-gen2-common.h b/include/configs/rcar-gen2-common.h
>>>> index 1ceee9a429..6069220406 100644
>>>> --- a/include/configs/rcar-gen2-common.h
>>>> +++ b/include/configs/rcar-gen2-common.h
>>>> @@ -15,6 +15,10 @@
>>>>  #define CONFIG_SETUP_MEMORY_TAGS
>>>>  #define CONFIG_INITRD_TAG
>>>>  
>>>> +#ifdef CONFIG_SPL
>>>> +#define CONFIG_SPL_TARGET	"spl/u-boot-spl.srec"
>>>> +#endif
>>>> +
>>>>  #undef	CONFIG_SHOW_BOOT_PROGRESS
>>>>  
>>>>  #define CONFIG_ARCH_CPU_INIT
>>>
>>> Can you please convert CONFIG_SPL_TARGET to CONFIG_SPL_BUILD_TARGET, to
>>> match CONFIG_BUILD_TARGET and migrate it after CONFIG_BUILD_TARGET?
>>> Thanks!
>>
>> Yeah, after the release. I dont plan to mess with it before the release.
>> Or are you planning to convert BUILD_TARGET to Kconfig _before_ ?
> 
> I would be happy enough to take both of those at this point, yes, as
> they can be easily verified.  Thanks!

I'll add it to my todo ...

-- 
Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2018-02-27 19:40 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-26 19:25 [U-Boot] [PATCH 1/2] Makefile: add u-boot-spl.srec target Marek Vasut
2018-02-26 19:25 ` [U-Boot] [PATCH 2/2] ARM: rmobile: Build u-boot-spl.srec on Gen2 Marek Vasut
2018-02-26 20:00   ` Tom Rini
2018-02-26 20:50     ` Marek Vasut
2018-02-27  0:00       ` Tom Rini
2018-02-27 19:40         ` Marek Vasut
2018-02-26 19:59 ` [U-Boot] [PATCH 1/2] Makefile: add u-boot-spl.srec target Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox