* [U-Boot] [PATCH] scripts: use CROSS_COMPILE environment variable @ 2018-03-02 16:24 Stefan Agner 2018-03-02 16:33 ` Lukasz Majewski 0 siblings, 1 reply; 7+ messages in thread From: Stefan Agner @ 2018-03-02 16:24 UTC (permalink / raw) To: u-boot From: Stefan Agner <stefan.agner@toradex.com> Make sure we use objcopy from the cross compiler toolchain. Signed-off-by: Stefan Agner <stefan.agner@toradex.com> --- scripts/get_default_envs.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/get_default_envs.sh b/scripts/get_default_envs.sh index 7955db60e5..84e9f51695 100755 --- a/scripts/get_default_envs.sh +++ b/scripts/get_default_envs.sh @@ -24,7 +24,8 @@ cp ${env_obj_file_path} ${ENV_OBJ_FILE_COPY} # NOTE: objcopy saves its output to file passed in # (copy_env_common.o in this case) -objcopy -O binary -j ".rodata.default_environment" ${ENV_OBJ_FILE_COPY} +${CROSS_COMPILE}objcopy -O binary -j ".rodata.default_environment" \ + ${ENV_OBJ_FILE_COPY} # Replace default '\0' with '\n' and sort entries tr '\0' '\n' < ${ENV_OBJ_FILE_COPY} | sort -u -- 2.16.2 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] scripts: use CROSS_COMPILE environment variable 2018-03-02 16:24 [U-Boot] [PATCH] scripts: use CROSS_COMPILE environment variable Stefan Agner @ 2018-03-02 16:33 ` Lukasz Majewski 2018-03-02 17:08 ` Stefan Agner 2018-03-03 21:31 ` Stefan Agner 0 siblings, 2 replies; 7+ messages in thread From: Lukasz Majewski @ 2018-03-02 16:33 UTC (permalink / raw) To: u-boot Hi Stefan, > From: Stefan Agner <stefan.agner@toradex.com> > > Make sure we use objcopy from the cross compiler toolchain. > > Signed-off-by: Stefan Agner <stefan.agner@toradex.com> > --- > scripts/get_default_envs.sh | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/scripts/get_default_envs.sh b/scripts/get_default_envs.sh > index 7955db60e5..84e9f51695 100755 > --- a/scripts/get_default_envs.sh > +++ b/scripts/get_default_envs.sh > @@ -24,7 +24,8 @@ cp ${env_obj_file_path} ${ENV_OBJ_FILE_COPY} > > # NOTE: objcopy saves its output to file passed in > # (copy_env_common.o in this case) > -objcopy -O binary -j ".rodata.default_environment" > ${ENV_OBJ_FILE_COPY} +${CROSS_COMPILE}objcopy -O binary -j > ".rodata.default_environment" \ > + ${ENV_OBJ_FILE_COPY} Stefan, could you check if this is not already solved in newest mainline? It seems like this is v2 or v1 of the patch. The v3 was finally pulled to main line: +${OBJCOPY} -O binary -j ".rodata.default_environment" ${ENV_OBJ_FILE_COPY} > > # Replace default '\0' with '\n' and sort entries > tr '\0' '\n' < ${ENV_OBJ_FILE_COPY} | sort -u Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180302/5cb5a050/attachment.sig> ^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] scripts: use CROSS_COMPILE environment variable 2018-03-02 16:33 ` Lukasz Majewski @ 2018-03-02 17:08 ` Stefan Agner 2018-03-03 21:31 ` Stefan Agner 1 sibling, 0 replies; 7+ messages in thread From: Stefan Agner @ 2018-03-02 17:08 UTC (permalink / raw) To: u-boot Hi Lukasz, On 02.03.2018 17:33, Lukasz Majewski wrote: > Hi Stefan, > >> From: Stefan Agner <stefan.agner@toradex.com> >> >> Make sure we use objcopy from the cross compiler toolchain. >> >> Signed-off-by: Stefan Agner <stefan.agner@toradex.com> >> --- >> scripts/get_default_envs.sh | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/scripts/get_default_envs.sh b/scripts/get_default_envs.sh >> index 7955db60e5..84e9f51695 100755 >> --- a/scripts/get_default_envs.sh >> +++ b/scripts/get_default_envs.sh >> @@ -24,7 +24,8 @@ cp ${env_obj_file_path} ${ENV_OBJ_FILE_COPY} >> >> # NOTE: objcopy saves its output to file passed in >> # (copy_env_common.o in this case) >> -objcopy -O binary -j ".rodata.default_environment" >> ${ENV_OBJ_FILE_COPY} +${CROSS_COMPILE}objcopy -O binary -j >> ".rodata.default_environment" \ >> + ${ENV_OBJ_FILE_COPY} > > Stefan, could you check if this is not already solved in newest > mainline? > > It seems like this is v2 or v1 of the patch. The v3 was finally pulled > to main line: > > +${OBJCOPY} -O binary -j ".rodata.default_environment" > ${ENV_OBJ_FILE_COPY} > Oh I see there is a patch on master yes. It seems not to work here though: $ ./scripts/get_default_envs.sh . arm-linux-gnueabihf-objcopy:stPZVLWM: Invalid operation Need to look closer -- Stefan >> >> # Replace default '\0' with '\n' and sort entries >> tr '\0' '\n' < ${ENV_OBJ_FILE_COPY} | sort -u > > > > > Best regards, > > Lukasz Majewski > > -- > > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de ^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] scripts: use CROSS_COMPILE environment variable 2018-03-02 16:33 ` Lukasz Majewski 2018-03-02 17:08 ` Stefan Agner @ 2018-03-03 21:31 ` Stefan Agner 2018-03-03 22:02 ` Lukasz Majewski 1 sibling, 1 reply; 7+ messages in thread From: Stefan Agner @ 2018-03-03 21:31 UTC (permalink / raw) To: u-boot On 02.03.2018 17:33, Lukasz Majewski wrote: > Hi Stefan, > >> From: Stefan Agner <stefan.agner@toradex.com> >> >> Make sure we use objcopy from the cross compiler toolchain. >> >> Signed-off-by: Stefan Agner <stefan.agner@toradex.com> >> --- >> scripts/get_default_envs.sh | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/scripts/get_default_envs.sh b/scripts/get_default_envs.sh >> index 7955db60e5..84e9f51695 100755 >> --- a/scripts/get_default_envs.sh >> +++ b/scripts/get_default_envs.sh >> @@ -24,7 +24,8 @@ cp ${env_obj_file_path} ${ENV_OBJ_FILE_COPY} >> >> # NOTE: objcopy saves its output to file passed in >> # (copy_env_common.o in this case) >> -objcopy -O binary -j ".rodata.default_environment" >> ${ENV_OBJ_FILE_COPY} +${CROSS_COMPILE}objcopy -O binary -j >> ".rodata.default_environment" \ >> + ${ENV_OBJ_FILE_COPY} > > Stefan, could you check if this is not already solved in newest > mainline? > > It seems like this is v2 or v1 of the patch. The v3 was finally pulled > to main line: > > +${OBJCOPY} -O binary -j ".rodata.default_environment" > ${ENV_OBJ_FILE_COPY} > Tested again with vanilla mainline, and the scripts works indeed fine and does exactly what I tried to achieve. Thanks Lukasz. I did backport it, but had to set the object file back to env_common.o for our case. So disregard this patch. -- Stefan >> >> # Replace default '\0' with '\n' and sort entries >> tr '\0' '\n' < ${ENV_OBJ_FILE_COPY} | sort -u > > > > > Best regards, > > Lukasz Majewski > > -- > > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de ^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] scripts: use CROSS_COMPILE environment variable 2018-03-03 21:31 ` Stefan Agner @ 2018-03-03 22:02 ` Lukasz Majewski 2018-03-23 15:30 ` Stefan Agner 0 siblings, 1 reply; 7+ messages in thread From: Lukasz Majewski @ 2018-03-03 22:02 UTC (permalink / raw) To: u-boot Hi Stefan, > On 02.03.2018 17:33, Lukasz Majewski wrote: > > Hi Stefan, > > > >> From: Stefan Agner <stefan.agner@toradex.com> > >> > >> Make sure we use objcopy from the cross compiler toolchain. > >> > >> Signed-off-by: Stefan Agner <stefan.agner@toradex.com> > >> --- > >> scripts/get_default_envs.sh | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/scripts/get_default_envs.sh > >> b/scripts/get_default_envs.sh index 7955db60e5..84e9f51695 100755 > >> --- a/scripts/get_default_envs.sh > >> +++ b/scripts/get_default_envs.sh > >> @@ -24,7 +24,8 @@ cp ${env_obj_file_path} ${ENV_OBJ_FILE_COPY} > >> > >> # NOTE: objcopy saves its output to file passed in > >> # (copy_env_common.o in this case) > >> -objcopy -O binary -j ".rodata.default_environment" > >> ${ENV_OBJ_FILE_COPY} +${CROSS_COMPILE}objcopy -O binary -j > >> ".rodata.default_environment" \ > >> + ${ENV_OBJ_FILE_COPY} > > > > Stefan, could you check if this is not already solved in newest > > mainline? > > > > It seems like this is v2 or v1 of the patch. The v3 was finally > > pulled to main line: > > > > +${OBJCOPY} -O binary -j ".rodata.default_environment" > > ${ENV_OBJ_FILE_COPY} > > > > Tested again with vanilla mainline, and the scripts works indeed fine > and does exactly what I tried to achieve. Thanks Lukasz. Happy to could help. I've also tested this patch with OE|Yocto u-boot (for 2.3.3) recipe to generate images with primary and redundant envs. I will try to upstream it, so creating env images would be easy. > > I did backport it, but had to set the object file back to env_common.o > for our case. > > So disregard this patch. Ok. > > -- > Stefan > > >> > >> # Replace default '\0' with '\n' and sort entries > >> tr '\0' '\n' < ${ENV_OBJ_FILE_COPY} | sort -u > > > > > > > > > > Best regards, > > > > Lukasz Majewski > > > > -- > > > > DENX Software Engineering GmbH, Managing Director: Wolfgang > > Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, > > Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: > > wd at denx.de Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180303/03a03592/attachment.sig> ^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] scripts: use CROSS_COMPILE environment variable 2018-03-03 22:02 ` Lukasz Majewski @ 2018-03-23 15:30 ` Stefan Agner 2018-03-23 16:06 ` Lukasz Majewski 0 siblings, 1 reply; 7+ messages in thread From: Stefan Agner @ 2018-03-23 15:30 UTC (permalink / raw) To: u-boot On 03.03.2018 23:02, Lukasz Majewski wrote: > Hi Stefan, > >> On 02.03.2018 17:33, Lukasz Majewski wrote: >> > Hi Stefan, >> > >> >> From: Stefan Agner <stefan.agner@toradex.com> >> >> >> >> Make sure we use objcopy from the cross compiler toolchain. >> >> >> >> Signed-off-by: Stefan Agner <stefan.agner@toradex.com> >> >> --- >> >> scripts/get_default_envs.sh | 3 ++- >> >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> >> >> diff --git a/scripts/get_default_envs.sh >> >> b/scripts/get_default_envs.sh index 7955db60e5..84e9f51695 100755 >> >> --- a/scripts/get_default_envs.sh >> >> +++ b/scripts/get_default_envs.sh >> >> @@ -24,7 +24,8 @@ cp ${env_obj_file_path} ${ENV_OBJ_FILE_COPY} >> >> >> >> # NOTE: objcopy saves its output to file passed in >> >> # (copy_env_common.o in this case) >> >> -objcopy -O binary -j ".rodata.default_environment" >> >> ${ENV_OBJ_FILE_COPY} +${CROSS_COMPILE}objcopy -O binary -j >> >> ".rodata.default_environment" \ >> >> + ${ENV_OBJ_FILE_COPY} >> > >> > Stefan, could you check if this is not already solved in newest >> > mainline? >> > >> > It seems like this is v2 or v1 of the patch. The v3 was finally >> > pulled to main line: >> > >> > +${OBJCOPY} -O binary -j ".rodata.default_environment" >> > ${ENV_OBJ_FILE_COPY} >> > >> >> Tested again with vanilla mainline, and the scripts works indeed fine >> and does exactly what I tried to achieve. Thanks Lukasz. > > Happy to could help. > > I've also tested this patch with OE|Yocto u-boot (for 2.3.3) recipe to > generate images with primary and redundant envs. > > I will try to upstream it, so creating env images would be easy. > That sounds interesting. Did you already send a patch for this? Do you happen to have a link/patchfile you could share? -- Stefan >> >> I did backport it, but had to set the object file back to env_common.o >> for our case. >> >> So disregard this patch. > > Ok. > >> >> -- >> Stefan >> >> >> >> >> # Replace default '\0' with '\n' and sort entries >> >> tr '\0' '\n' < ${ENV_OBJ_FILE_COPY} | sort -u >> > >> > >> > >> > >> > Best regards, >> > >> > Lukasz Majewski >> > >> > -- >> > >> > DENX Software Engineering GmbH, Managing Director: Wolfgang >> > Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, >> > Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: >> > wd at denx.de > > > > > Best regards, > > Lukasz Majewski > > -- > > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de ^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] scripts: use CROSS_COMPILE environment variable 2018-03-23 15:30 ` Stefan Agner @ 2018-03-23 16:06 ` Lukasz Majewski 0 siblings, 0 replies; 7+ messages in thread From: Lukasz Majewski @ 2018-03-23 16:06 UTC (permalink / raw) To: u-boot On Fri, 23 Mar 2018 16:30:56 +0100 Stefan Agner <stefan@agner.ch> wrote: > On 03.03.2018 23:02, Lukasz Majewski wrote: > > Hi Stefan, > > > >> On 02.03.2018 17:33, Lukasz Majewski wrote: > >> > Hi Stefan, > >> > > >> >> From: Stefan Agner <stefan.agner@toradex.com> > >> >> > >> >> Make sure we use objcopy from the cross compiler toolchain. > >> >> > >> >> Signed-off-by: Stefan Agner <stefan.agner@toradex.com> > >> >> --- > >> >> scripts/get_default_envs.sh | 3 ++- > >> >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> >> > >> >> diff --git a/scripts/get_default_envs.sh > >> >> b/scripts/get_default_envs.sh index 7955db60e5..84e9f51695 > >> >> 100755 --- a/scripts/get_default_envs.sh > >> >> +++ b/scripts/get_default_envs.sh > >> >> @@ -24,7 +24,8 @@ cp ${env_obj_file_path} ${ENV_OBJ_FILE_COPY} > >> >> > >> >> # NOTE: objcopy saves its output to file passed in > >> >> # (copy_env_common.o in this case) > >> >> -objcopy -O binary -j ".rodata.default_environment" > >> >> ${ENV_OBJ_FILE_COPY} +${CROSS_COMPILE}objcopy -O binary -j > >> >> ".rodata.default_environment" \ > >> >> + ${ENV_OBJ_FILE_COPY} > >> > > >> > Stefan, could you check if this is not already solved in newest > >> > mainline? > >> > > >> > It seems like this is v2 or v1 of the patch. The v3 was finally > >> > pulled to main line: > >> > > >> > +${OBJCOPY} -O binary -j ".rodata.default_environment" > >> > ${ENV_OBJ_FILE_COPY} > >> > > >> > >> Tested again with vanilla mainline, and the scripts works indeed > >> fine and does exactly what I tried to achieve. Thanks Lukasz. > > > > Happy to could help. > > > > I've also tested this patch with OE|Yocto u-boot (for 2.3.3) recipe > > to generate images with primary and redundant envs. > > > > I will try to upstream it, so creating env images would be easy. > > > > That sounds interesting. > > Did you already send a patch for this? Do you happen to have a > link/patchfile you could share? Unfortunately not...... It is not in a shape to be sent to OE mailing list. > > -- > Stefan > > >> > >> I did backport it, but had to set the object file back to > >> env_common.o for our case. > >> > >> So disregard this patch. > > > > Ok. > > > >> > >> -- > >> Stefan > >> > >> >> > >> >> # Replace default '\0' with '\n' and sort entries > >> >> tr '\0' '\n' < ${ENV_OBJ_FILE_COPY} | sort -u > >> > > >> > > >> > > >> > > >> > Best regards, > >> > > >> > Lukasz Majewski > >> > > >> > -- > >> > > >> > DENX Software Engineering GmbH, Managing Director: Wolfgang > >> > Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 > >> > Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: > >> > (+49)-8142-66989-80 Email: wd at denx.de > > > > > > > > > > Best regards, > > > > Lukasz Majewski > > > > -- > > > > DENX Software Engineering GmbH, Managing Director: Wolfgang > > Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, > > Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: > > wd at denx.de Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180323/a73071c6/attachment.sig> ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-03-23 16:06 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-03-02 16:24 [U-Boot] [PATCH] scripts: use CROSS_COMPILE environment variable Stefan Agner 2018-03-02 16:33 ` Lukasz Majewski 2018-03-02 17:08 ` Stefan Agner 2018-03-03 21:31 ` Stefan Agner 2018-03-03 22:02 ` Lukasz Majewski 2018-03-23 15:30 ` Stefan Agner 2018-03-23 16:06 ` Lukasz Majewski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox