From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] scripts: use CROSS_COMPILE environment variable
Date: Sat, 3 Mar 2018 23:02:01 +0100 [thread overview]
Message-ID: <20180303230201.0c4f0e92@jawa> (raw)
In-Reply-To: <ea6f5b8ca82d737888d6b6668825e5a1@agner.ch>
Hi Stefan,
> On 02.03.2018 17:33, Lukasz Majewski wrote:
> > Hi Stefan,
> >
> >> From: Stefan Agner <stefan.agner@toradex.com>
> >>
> >> Make sure we use objcopy from the cross compiler toolchain.
> >>
> >> Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
> >> ---
> >> scripts/get_default_envs.sh | 3 ++-
> >> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/scripts/get_default_envs.sh
> >> b/scripts/get_default_envs.sh index 7955db60e5..84e9f51695 100755
> >> --- a/scripts/get_default_envs.sh
> >> +++ b/scripts/get_default_envs.sh
> >> @@ -24,7 +24,8 @@ cp ${env_obj_file_path} ${ENV_OBJ_FILE_COPY}
> >>
> >> # NOTE: objcopy saves its output to file passed in
> >> # (copy_env_common.o in this case)
> >> -objcopy -O binary -j ".rodata.default_environment"
> >> ${ENV_OBJ_FILE_COPY} +${CROSS_COMPILE}objcopy -O binary -j
> >> ".rodata.default_environment" \
> >> + ${ENV_OBJ_FILE_COPY}
> >
> > Stefan, could you check if this is not already solved in newest
> > mainline?
> >
> > It seems like this is v2 or v1 of the patch. The v3 was finally
> > pulled to main line:
> >
> > +${OBJCOPY} -O binary -j ".rodata.default_environment"
> > ${ENV_OBJ_FILE_COPY}
> >
>
> Tested again with vanilla mainline, and the scripts works indeed fine
> and does exactly what I tried to achieve. Thanks Lukasz.
Happy to could help.
I've also tested this patch with OE|Yocto u-boot (for 2.3.3) recipe to
generate images with primary and redundant envs.
I will try to upstream it, so creating env images would be easy.
>
> I did backport it, but had to set the object file back to env_common.o
> for our case.
>
> So disregard this patch.
Ok.
>
> --
> Stefan
>
> >>
> >> # Replace default '\0' with '\n' and sort entries
> >> tr '\0' '\n' < ${ENV_OBJ_FILE_COPY} | sort -u
> >
> >
> >
> >
> > Best regards,
> >
> > Lukasz Majewski
> >
> > --
> >
> > DENX Software Engineering GmbH, Managing Director: Wolfgang
> > Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,
> > Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email:
> > wd at denx.de
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180303/03a03592/attachment.sig>
next prev parent reply other threads:[~2018-03-03 22:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 16:24 [U-Boot] [PATCH] scripts: use CROSS_COMPILE environment variable Stefan Agner
2018-03-02 16:33 ` Lukasz Majewski
2018-03-02 17:08 ` Stefan Agner
2018-03-03 21:31 ` Stefan Agner
2018-03-03 22:02 ` Lukasz Majewski [this message]
2018-03-23 15:30 ` Stefan Agner
2018-03-23 16:06 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180303230201.0c4f0e92@jawa \
--to=lukma@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox