From: Tuomas Tynkkynen <tuomas@tuxera.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Default CONFIG_SYS_CBSIZE too low
Date: Mon, 5 Mar 2018 23:20:08 +0200 [thread overview]
Message-ID: <20180305232008.02edd467@duuni> (raw)
Hi,
I was playing around with qemu_arm and qemu_arm64 and noticed some images
using the distro bootcmd infrastructure failed to boot there due to the buffer
for kernel command line arguments (which is determined by CONFIG_SYS_CBSIZE)
was too small. I found this odd given the images worked on some other boards
but turns out all of them bump it up from the default of 256:
include/configs/tegra-common.h:#define CONFIG_SYS_CBSIZE (1024 * 2) /* Console I/O Buffer Size */
include/configs/sunxi-common.h:#define CONFIG_SYS_CBSIZE 1024 /* Console I/O Buffer Size */
include/configs/mx6_common.h:#define CONFIG_SYS_CBSIZE 512
include/configs/rpi.h:#define CONFIG_SYS_CBSIZE 1024
For 2018.03 I'll send a patch to increase it for qemu-arm too but I think
for the next release we should increase default (in config_fallbacks.h) so
that the user experience is consistent on all boards. But, I wonder how
safe it is to increase it for these boards low on RAM and stack?
Should it perhaps be increased only for boards with CONFIG_DISTRO_DEFAULTS
that are expected to have enough resources for everything and the kitchen
sink? Or decoupling the kernel command line length from CONFIG_SYS_CBSIZE
and using malloc()? Other ideas?
Thanks,
- Tuomas
reply other threads:[~2018-03-05 21:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180305232008.02edd467@duuni \
--to=tuomas@tuxera.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox