[U-Boot] [PATCH 1/1] sunxi: video: mark framebuffer as EFI reserved memory

[U-Boot] [PATCH 1/1] sunxi: video: mark framebuffer as EFI reserved memory

[Heinrich Schuchardt]

Inform the EFI subsystem that the framebuffer memory is reserved.

Without the patch the AllocatePool boot service allocates memory from the
framebuffer which will will be overwritten by screen output.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 drivers/video/sunxi/sunxi_display.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/video/sunxi/sunxi_display.c b/drivers/video/sunxi/sunxi_display.c
index f191ef16c6..4da169fffd 100644
--- a/drivers/video/sunxi/sunxi_display.c
+++ b/drivers/video/sunxi/sunxi_display.c
@@ -8,6 +8,7 @@
  */
 
 #include <common.h>
+#include <efi_loader.h>
 
 #include <asm/arch/clock.h>
 #include <asm/arch/display.h>
@@ -1207,6 +1208,13 @@ void *video_hw_init(void)
 		      gd->bd->bi_dram[0].size - sunxi_display.fb_size;
 	sunxi_engines_init();
 
+#ifdef CONFIG_EFI_LOADER
+	efi_add_memory_map(gd->fb_base,
+			   ALIGN(sunxi_display.fb_size, EFI_PAGE_SIZE) >>
+			   EFI_PAGE_SHIFT,
+			   EFI_RESERVED_MEMORY_TYPE, false);
+#endif
+
 	fb_dma_addr = gd->fb_base - CONFIG_SYS_SDRAM_BASE;
 	sunxi_display.fb_addr = gd->fb_base;
 	if (overscan_offset) {
-- 
2.16.1

[U-Boot] [PATCH 1/1] sunxi: video: mark framebuffer as EFI reserved memory

[Anatolij Gustschin]

Hi Heinrich,

On Sat,  3 Mar 2018 10:30:17 +0100
Heinrich Schuchardt xypron.glpk at gmx.de wrote:

> Inform the EFI subsystem that the framebuffer memory is reserved.
> 
> Without the patch the AllocatePool boot service allocates memory from the
> framebuffer which will will be overwritten by screen output.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Should this patch be merged into v2018.03 release or can it wait?

Thanks,

Anatolij

[U-Boot] [PATCH 1/1] sunxi: video: mark framebuffer as EFI reserved memory

[Heinrich Schuchardt]

On 03/05/2018 08:19 AM, Anatolij Gustschin wrote:
> Hi Heinrich,
> 
> On Sat,  3 Mar 2018 10:30:17 +0100
> Heinrich Schuchardt xypron.glpk at gmx.de wrote:
> 
>> Inform the EFI subsystem that the framebuffer memory is reserved.
>>
>> Without the patch the AllocatePool boot service allocates memory from the
>> framebuffer which will will be overwritten by screen output.
>>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> 
> Should this patch be merged into v2018.03 release or can it wait?

Hello Anatolij,

v2018.05 is fine. The problem will become visible in more cases with

[PATCH 1/1] efi_loader: efi_allocate_pages is too restrictive
https://patchwork.ozlabs.org/patch/881055/
https://lists.denx.de/pipermail/u-boot/2018-March/321840.html

which is also pending.

Regards

Heinrich

[U-Boot] [PATCH 1/1] sunxi: video: mark framebuffer as EFI reserved memory

[Anatolij Gustschin]

Hello Heinrich,

On Mon, 5 Mar 2018 17:55:52 +0100
Heinrich Schuchardt xypron.glpk at gmx.de wrote:
...
> v2018.05 is fine. The problem will become visible in more cases with
> 
> [PATCH 1/1] efi_loader: efi_allocate_pages is too restrictive
> https://patchwork.ozlabs.org/patch/881055/
> https://lists.denx.de/pipermail/u-boot/2018-March/321840.html
> 
> which is also pending.

Okay, I'll apply your patch when efi_loader patch is merged.

Thanks,

Anatolij

[U-Boot] [PATCH 1/1] sunxi: video: mark framebuffer as EFI reserved memory

[Heinrich Schuchardt]

On 03/06/2018 11:21 AM, Anatolij Gustschin wrote:
> Hello Heinrich,
> 
> On Mon, 5 Mar 2018 17:55:52 +0100
> Heinrich Schuchardt xypron.glpk at gmx.de wrote:
> ...
>> v2018.05 is fine. The problem will become visible in more cases with
>>
>> [PATCH 1/1] efi_loader: efi_allocate_pages is too restrictive
>> https://patchwork.ozlabs.org/patch/881055/
>> https://lists.denx.de/pipermail/u-boot/2018-March/321840.html
>>
>> which is also pending.
> 
> Okay, I'll apply your patch when efi_loader patch is merged.

If efi_allocate_memory is called with type = EFI_ALLOCATE_MAX_ADDRESS we
can already have an error. So, please, put the patch into your v2018.05
queue. There is no need to wait for Alex.

Regards

Heinrich

[U-Boot] [PATCH 1/1] sunxi: video: mark framebuffer as EFI reserved memory

[Anatolij Gustschin]

On Sat,  3 Mar 2018 10:30:17 +0100
Heinrich Schuchardt xypron.glpk at gmx.de wrote:

> Inform the EFI subsystem that the framebuffer memory is reserved.
> 
> Without the patch the AllocatePool boot service allocates memory from the
> framebuffer which will will be overwritten by screen output.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  drivers/video/sunxi/sunxi_display.c | 8 ++++++++
>  1 file changed, 8 insertions(+)

Applied to u-boot-video/next, thanks!

--
Anatolij

[U-Boot] [PATCH 1/1] sunxi: video: mark framebuffer as EFI reserved memory

[Anatolij Gustschin]

On Fri, 9 Mar 2018 16:49:49 +0100
Heinrich Schuchardt xypron.glpk at gmx.de wrote:
...
> If efi_allocate_memory is called with type = EFI_ALLOCATE_MAX_ADDRESS we
> can already have an error. So, please, put the patch into your v2018.05
> queue. There is no need to wait for Alex.

okay, done.

--
Anatolij