From: Liam Beguin <liambeguin@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 2/7] cmd: sf: fix map_physmem check
Date: Tue, 13 Mar 2018 22:03:02 -0400 [thread overview]
Message-ID: <20180314020307.23475-3-liambeguin@gmail.com> (raw)
In-Reply-To: <20180314020307.23475-1-liambeguin@gmail.com>
Make sure 0x00 is a valid address to read to. If `addr` is 0x00 then
map_physmem() will return 0 which should be a valid address.
Signed-off-by: Liam Beguin <liambeguin@gmail.com>
---
cmd/sf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmd/sf.c b/cmd/sf.c
index f971eec781cc..e7ff9a646208 100644
--- a/cmd/sf.c
+++ b/cmd/sf.c
@@ -287,7 +287,7 @@ static int do_spi_flash_read_write(int argc, char * const argv[])
}
buf = map_physmem(addr, len, MAP_WRBACK);
- if (!buf) {
+ if (!buf && addr) {
puts("Failed to map physical memory\n");
return 1;
}
--
2.16.1.72.g5be1f00a9a70
next prev parent reply other threads:[~2018-03-14 2:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 2:03 [U-Boot] [PATCH v3 0/7] add inital SF tests Liam Beguin
2018-03-14 2:03 ` [U-Boot] [PATCH v3 1/7] spi: spi_flash: do not fail silently on bad user input Liam Beguin
2018-03-14 2:03 ` Liam Beguin [this message]
2018-03-14 2:03 ` [U-Boot] [PATCH v3 3/7] test/py: README: fix typo Liam Beguin
2018-03-14 2:03 ` [U-Boot] [PATCH v3 4/7] test/py: README: add HOSTNAME to PYTHONPATH Liam Beguin
2018-03-14 2:03 ` [U-Boot] [PATCH v3 5/7] test/py: do not import pytest multiple times Liam Beguin
2018-03-14 2:03 ` [U-Boot] [PATCH v3 6/7] test/py: add generic CRC32 function Liam Beguin
2018-03-14 2:03 ` [U-Boot] [PATCH v3 7/7] test/py: add spi_flash tests Liam Beguin
2018-03-14 14:35 ` Michal Simek
2018-03-14 15:59 ` Liam Beguin
2018-03-15 6:35 ` Michal Simek
2018-03-14 16:17 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180314020307.23475-3-liambeguin@gmail.com \
--to=liambeguin@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox