From: Tuomas Tynkkynen <tuomas@tuxera.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] lan7xxx: Require phylib
Date: Fri, 16 Mar 2018 05:16:21 +0200 [thread overview]
Message-ID: <20180316051621.70569c80@duuni> (raw)
In-Reply-To: <20180315141020.11581-1-agraf@suse.de>
Hi,
On Thu, 15 Mar 2018 15:10:20 +0100
Alexander Graf <agraf@suse.de> wrote:
> The lan75xx and lan78xx drivers need to drive their phy via the generic
> phylib framework. Let's reflect that dependency in Kconfig, so that we
> don't get build errors when phylib does not get selected.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
> drivers/usb/eth/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/eth/Kconfig b/drivers/usb/eth/Kconfig
> index 496a6d1933..2f6bfa8e71 100644
> --- a/drivers/usb/eth/Kconfig
> +++ b/drivers/usb/eth/Kconfig
> @@ -23,6 +23,7 @@ config USB_ETHER_ASIX88179
> config USB_ETHER_LAN75XX
> bool "Microchip LAN75XX support"
> depends on USB_HOST_ETHER
> + depends on PHYLIB
'select PHYLIB' seems more appropriate here (and there are already 17
drivers selecting it and none using 'depends on'.)
next prev parent reply other threads:[~2018-03-16 3:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 14:10 [U-Boot] [PATCH] lan7xxx: Require phylib Alexander Graf
2018-03-15 18:58 ` Joe Hershberger
2018-03-16 3:16 ` Tuomas Tynkkynen [this message]
2018-03-16 17:29 ` Joe Hershberger
2018-03-26 19:26 ` [U-Boot] " Joe Hershberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180316051621.70569c80@duuni \
--to=tuomas@tuxera.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox