public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] drivers: reset: convert to use live dt
@ 2018-03-17 11:24 Álvaro Fernández Rojas
  2018-03-19 17:59 ` Simon Glass
  0 siblings, 1 reply; 2+ messages in thread
From: Álvaro Fernández Rojas @ 2018-03-17 11:24 UTC (permalink / raw)
  To: u-boot

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
---
 drivers/reset/reset-bcm6345.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/reset/reset-bcm6345.c b/drivers/reset/reset-bcm6345.c
index ebf6bee9e6..9679d7d4b2 100644
--- a/drivers/reset/reset-bcm6345.c
+++ b/drivers/reset/reset-bcm6345.c
@@ -68,13 +68,12 @@ static int bcm6345_reset_probe(struct udevice *dev)
 {
 	struct bcm6345_reset_priv *priv = dev_get_priv(dev);
 	fdt_addr_t addr;
-	fdt_size_t size;
 
-	addr = devfdt_get_addr_size_index(dev, 0, &size);
+	addr = dev_read_addr(dev);
 	if (addr == FDT_ADDR_T_NONE)
 		return -EINVAL;
 
-	priv->regs = ioremap(addr, size);
+	priv->regs = ioremap(addr, 0);
 
 	return 0;
 }
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH] drivers: reset: convert to use live dt
  2018-03-17 11:24 [U-Boot] [PATCH] drivers: reset: convert to use live dt Álvaro Fernández Rojas
@ 2018-03-19 17:59 ` Simon Glass
  0 siblings, 0 replies; 2+ messages in thread
From: Simon Glass @ 2018-03-19 17:59 UTC (permalink / raw)
  To: u-boot

On 17 March 2018 at 05:24, Álvaro Fernández Rojas <noltari@gmail.com> wrote:
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
>  drivers/reset/reset-bcm6345.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

Should we have a dev_read_addr_size()?

>
> diff --git a/drivers/reset/reset-bcm6345.c b/drivers/reset/reset-bcm6345.c
> index ebf6bee9e6..9679d7d4b2 100644
> --- a/drivers/reset/reset-bcm6345.c
> +++ b/drivers/reset/reset-bcm6345.c
> @@ -68,13 +68,12 @@ static int bcm6345_reset_probe(struct udevice *dev)
>  {
>         struct bcm6345_reset_priv *priv = dev_get_priv(dev);
>         fdt_addr_t addr;
> -       fdt_size_t size;
>
> -       addr = devfdt_get_addr_size_index(dev, 0, &size);
> +       addr = dev_read_addr(dev);
>         if (addr == FDT_ADDR_T_NONE)
>                 return -EINVAL;
>
> -       priv->regs = ioremap(addr, size);
> +       priv->regs = ioremap(addr, 0);
>
>         return 0;
>  }
> --
> 2.11.0
>

Regards,
Simon

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-03-19 17:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-17 11:24 [U-Boot] [PATCH] drivers: reset: convert to use live dt Álvaro Fernández Rojas
2018-03-19 17:59 ` Simon Glass

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox