public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 1/2] spi: bcm63xx_spi: convert to use live dt
@ 2018-03-17 11:27 Álvaro Fernández Rojas
  2018-03-17 11:27 ` [U-Boot] [PATCH 2/2] spi: bcm63xx_hsspi: " Álvaro Fernández Rojas
  2018-03-19 17:59 ` [U-Boot] [PATCH 1/2] spi: bcm63xx_spi: " Simon Glass
  0 siblings, 2 replies; 4+ messages in thread
From: Álvaro Fernández Rojas @ 2018-03-17 11:27 UTC (permalink / raw)
  To: u-boot

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
---
 drivers/spi/bcm63xx_spi.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/spi/bcm63xx_spi.c b/drivers/spi/bcm63xx_spi.c
index f0df6871d8..357b8ab6d7 100644
--- a/drivers/spi/bcm63xx_spi.c
+++ b/drivers/spi/bcm63xx_spi.c
@@ -16,8 +16,6 @@
 #include <wait_bit.h>
 #include <asm/io.h>
 
-DECLARE_GLOBAL_DATA_PTR;
-
 /* BCM6348 SPI core */
 #define SPI_6348_CLK			0x06
 #define SPI_6348_CMD			0x00
@@ -375,17 +373,15 @@ static int bcm63xx_spi_probe(struct udevice *dev)
 	struct reset_ctl rst_ctl;
 	struct clk clk;
 	fdt_addr_t addr;
-	fdt_size_t size;
 	int ret;
 
-	addr = devfdt_get_addr_size_index(dev, 0, &size);
+	addr = dev_read_addr(dev);
 	if (addr == FDT_ADDR_T_NONE)
 		return -EINVAL;
 
 	priv->regs = regs;
-	priv->base = ioremap(addr, size);
-	priv->num_cs = fdtdec_get_uint(gd->fdt_blob, dev_of_offset(dev),
-				       "num-cs", 8);
+	priv->base = ioremap(addr, 0);
+	priv->num_cs = dev_read_u32_default(dev, "num-cs", 8);
 
 	/* enable clock */
 	ret = clk_get_by_index(dev, 0, &clk);
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH 2/2] spi: bcm63xx_hsspi: convert to use live dt
  2018-03-17 11:27 [U-Boot] [PATCH 1/2] spi: bcm63xx_spi: convert to use live dt Álvaro Fernández Rojas
@ 2018-03-17 11:27 ` Álvaro Fernández Rojas
  2018-03-19 17:59   ` Simon Glass
  2018-03-19 17:59 ` [U-Boot] [PATCH 1/2] spi: bcm63xx_spi: " Simon Glass
  1 sibling, 1 reply; 4+ messages in thread
From: Álvaro Fernández Rojas @ 2018-03-17 11:27 UTC (permalink / raw)
  To: u-boot

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
---
 drivers/spi/bcm63xx_hsspi.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/spi/bcm63xx_hsspi.c b/drivers/spi/bcm63xx_hsspi.c
index 3393166a1e..ece1ed214c 100644
--- a/drivers/spi/bcm63xx_hsspi.c
+++ b/drivers/spi/bcm63xx_hsspi.c
@@ -16,8 +16,6 @@
 #include <wait_bit.h>
 #include <asm/io.h>
 
-DECLARE_GLOBAL_DATA_PTR;
-
 #define HSSPI_PP			0
 
 #define SPI_MAX_SYNC_CLOCK		30000000
@@ -339,16 +337,14 @@ static int bcm63xx_hsspi_probe(struct udevice *dev)
 	struct reset_ctl rst_ctl;
 	struct clk clk;
 	fdt_addr_t addr;
-	fdt_size_t size;
 	int ret;
 
-	addr = devfdt_get_addr_size_index(dev, 0, &size);
+	addr = dev_read_addr(dev);
 	if (addr == FDT_ADDR_T_NONE)
 		return -EINVAL;
 
-	priv->regs = ioremap(addr, size);
-	priv->num_cs = fdtdec_get_uint(gd->fdt_blob, dev_of_offset(dev),
-				       "num-cs", 8);
+	priv->regs = ioremap(addr, 0);
+	priv->num_cs = dev_read_u32_default(dev, "num-cs", 8);
 
 	/* enable clock */
 	ret = clk_get_by_name(dev, "hsspi", &clk);
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH 1/2] spi: bcm63xx_spi: convert to use live dt
  2018-03-17 11:27 [U-Boot] [PATCH 1/2] spi: bcm63xx_spi: convert to use live dt Álvaro Fernández Rojas
  2018-03-17 11:27 ` [U-Boot] [PATCH 2/2] spi: bcm63xx_hsspi: " Álvaro Fernández Rojas
@ 2018-03-19 17:59 ` Simon Glass
  1 sibling, 0 replies; 4+ messages in thread
From: Simon Glass @ 2018-03-19 17:59 UTC (permalink / raw)
  To: u-boot

On 17 March 2018 at 05:27, Álvaro Fernández Rojas <noltari@gmail.com> wrote:
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
>  drivers/spi/bcm63xx_spi.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH 2/2] spi: bcm63xx_hsspi: convert to use live dt
  2018-03-17 11:27 ` [U-Boot] [PATCH 2/2] spi: bcm63xx_hsspi: " Álvaro Fernández Rojas
@ 2018-03-19 17:59   ` Simon Glass
  0 siblings, 0 replies; 4+ messages in thread
From: Simon Glass @ 2018-03-19 17:59 UTC (permalink / raw)
  To: u-boot

On 17 March 2018 at 05:27, Álvaro Fernández Rojas <noltari@gmail.com> wrote:
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
>  drivers/spi/bcm63xx_hsspi.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)

It would be great to have a short commit message on these.

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-03-19 17:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-17 11:27 [U-Boot] [PATCH 1/2] spi: bcm63xx_spi: convert to use live dt Álvaro Fernández Rojas
2018-03-17 11:27 ` [U-Boot] [PATCH 2/2] spi: bcm63xx_hsspi: " Álvaro Fernández Rojas
2018-03-19 17:59   ` Simon Glass
2018-03-19 17:59 ` [U-Boot] [PATCH 1/2] spi: bcm63xx_spi: " Simon Glass

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox