From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= Date: Tue, 20 Mar 2018 09:49:32 +0100 Subject: [U-Boot] [PATCH 2/5] net: fec_mxc: simplify fec_get_miibus In-Reply-To: <20180310011957.21801-2-peng.fan@nxp.com> References: <20180310011957.21801-1-peng.fan@nxp.com> <20180310011957.21801-2-peng.fan@nxp.com> Message-ID: <20180320094932.45c38802@karo-electronics.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: u-boot@lists.denx.de Hi, On Sat, 10 Mar 2018 09:19:54 +0800 Peng Fan wrote: > No need to provide two prototype for this function. > Use ulong for the first parameter, then this function > could be shared for DM/non DM case. >=20 > Signed-off-by: Peng Fan > --- > drivers/net/fec_mxc.c | 13 ++----------- > include/netdev.h | 6 +----- > 2 files changed, 3 insertions(+), 16 deletions(-) >=20 > diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c > index 7c396d8d95..2bd4ba4ef1 100644 > --- a/drivers/net/fec_mxc.c > +++ b/drivers/net/fec_mxc.c > @@ -1021,18 +1021,9 @@ static void fec_free_descs(struct fec_priv *fec) > free(fec->tbd_base); > } > =20 > -#ifdef CONFIG_DM_ETH > -struct mii_dev *fec_get_miibus(struct udevice *dev, int dev_id) > -#else > -struct mii_dev *fec_get_miibus(uint32_t base_addr, int dev_id) > -#endif > +struct mii_dev *fec_get_miibus(ulong base_addr, int dev_id) > { > -#ifdef CONFIG_DM_ETH > - struct fec_priv *priv =3D dev_get_priv(dev); > - struct ethernet_regs *eth =3D priv->eth; > -#else > struct ethernet_regs *eth =3D (struct ethernet_regs *)(ulong)base_addr; > The (ulong) is redundant here. Lothar Wa=C3=9Fmann