From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Wed, 21 Mar 2018 12:31:11 +0100 Subject: [U-Boot] [PATCH v2 5/7] bootcount: spl: Extend SPL to support bootcount incrementation In-Reply-To: <925479215.12506.1521627635947@office.mailbox.org> References: <20180314172450.8385-1-lukma@denx.de> <20180314172450.8385-6-lukma@denx.de> <925479215.12506.1521627635947@office.mailbox.org> Message-ID: <20180321123111.417a1ad3@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: u-boot@lists.denx.de Hi Stefan, > > Lukasz Majewski hat am 14. M=C3=A4rz 2018 um 18:24 > > geschrieben: > >=20 > >=20 > > This patch adds support for incrementation of the bootcount in SPL. > > Such feature is necessary when we do want to use this feature with > > 'falcon' boot mode (which loads OS directly in SPL). > >=20 > > Signed-off-by: Lukasz Majewski > >=20 > > --- > >=20 > > Changes in v2: > > - New patch - as suggested by Stefan Roese - bootcount_inc() is > > called in common SPL code (./common/spl/spl.c), so other boards can > > also reuse it without modification > >=20 > > common/spl/spl.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > >=20 > > diff --git a/common/spl/spl.c b/common/spl/spl.c > > index b1ce56d0d0..01e7989869 100644 > > --- a/common/spl/spl.c > > +++ b/common/spl/spl.c > > @@ -20,6 +20,9 @@ > > #include > > #include > > #include > > +#ifdef CONFIG_SPL_BOOTCOUNT_LIMIT > > +#include > > +#endif =20 >=20 > Is this #ifdef necessary? If not, please remove it.=20 The problem is that after removing those #ifdefs I do have SPL build breaks on .... x86 arch. It seems like some kind of non-trival dependency introduced in generic bootcount.h u-boot file. I even thought about introducing new file - like bootcount_spl.h >=20 > > =20 > > DECLARE_GLOBAL_DATA_PTR; > > =20 > > @@ -411,6 +414,10 @@ void board_init_r(gd_t *dummy1, ulong dummy2) > > spl_board_init(); > > #endif > > =20 > > +#ifdef CONFIG_SPL_BOOTCOUNT_LIMIT > > + bootcount_inc(); > > +#endif > > + =20 >=20 > I think you can remove this #ifdef as well here. You have the > #ifdef in the header already. Yes, it can be removed. >=20 > Thanks, > Stefan Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: