public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@bootlin.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sunxi: improve throughput in the sunxi_mmc driver
Date: Fri, 6 Apr 2018 07:54:47 +0200	[thread overview]
Message-ID: <20180406055447.xsibdkcdxenhrsq5@flea> (raw)
In-Reply-To: <20180321111858.16576-1-maxime.ripard@bootlin.com>

Hi Jaehoon,

On Wed, Mar 21, 2018 at 12:18:58PM +0100, Maxime Ripard wrote:
> From: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> 
> Throughput tests have shown the sunxi_mmc driver to take over 10s to
> read 10MB from a fast eMMC device due to excessive delays in polling
> loops.
> 
> This commit restructures the main polling loops to use get_timer(...)
> to determine whether a (millisecond) timeout has expired.  We choose
> not to use the wait_bit function, as we don't need interruptability
> with ctrl-c and have at least one case where two bits (one for an
> error condition and another one for completion) need to be read and
> using wait_bit would have not added to the clarity.
> 
> The observed speedup in testing on a A31 is greater than 10x (e.g. a
> 10MB write decreases from 9.302s to 0.884s).
> 
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>

Any chance we can merge this for the next release?

Thanks!
Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2018-04-06  5:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-21 11:18 [U-Boot] [PATCH] sunxi: improve throughput in the sunxi_mmc driver Maxime Ripard
2018-03-29 13:40 ` Mylène Josserand
2018-04-04  6:43 ` Jagan Teki
2018-04-04  7:06   ` Maxime Ripard
2018-04-06  6:06     ` Jagan Teki
2018-04-24 19:57       ` Maxime Ripard
2018-04-24 20:16         ` Tom Rini
2018-04-25  5:01           ` Jagan Teki
2018-04-06  5:54 ` Maxime Ripard [this message]
2018-04-16 19:55   ` Maxime Ripard
2018-04-16 20:37     ` Michael Nazzareno Trimarchi
2018-04-20 20:10       ` Maxime Ripard
2018-04-20 20:49         ` Michael Nazzareno Trimarchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180406055447.xsibdkcdxenhrsq5@flea \
    --to=maxime.ripard@bootlin.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox